Skip to content

How to get your pull request accepted

Simon Hughes edited this page Jul 15, 2019 · 9 revisions

Have a read of How to write the perfect pull request

My requirements are simple:

  1. Edit the Generator project files. I have a build script which takes the Generator code, and creates the EF.Reverse.POCO.v3.ttinclude file. So editing and debugging is now all done in the C# Generator project.
  2. Always keep the changes to a minimum, so I can see exactly what's changed in regard to the pull request. I.e. No whitespace tidy up, etc.
  3. No tabs, only spaces (4).
  4. Only use C# 6 and below. Absolutely no C# 7 because VS 2015 cannot support the syntax.
  5. Don't move functions about, please leave them where they are.
  6. No new .ttinclude files. This will always get rejected.
  7. Don't be tempted to do a few different enhancements in one pull request. Have one pull request for one bug fix / enhancement.

Many thanks for taking the time to read this, and for wanting to contribute.

Clone this wiki locally