Skip to content

Commit 934b420

Browse files
Properly quote query string for freshdesk API (#50)
Per https://developers.freshdesk.com/api/#filter_tickets Co-authored-by: Fellipe Mendonça <[email protected]>
1 parent d483fff commit 934b420

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

freshdesk/v2/api.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,14 +154,17 @@ def filter_tickets(self, query, **kwargs):
154154
155155
query = "(ticket_field:integer OR ticket_field:'string') AND ticket_field:boolean"
156156
"""
157+
if(len(query) > 512):
158+
raise AttributeError('Query string can have up to 512 characters')
159+
157160
url = 'search/tickets?'
158161
page = 1 if not 'page' in kwargs else kwargs['page']
159162
per_page = 30
160163

161164
tickets = []
162165
while True:
163-
this_page = self._api._get(url + 'page=%d&query=%s'
164-
% (page, repr(query)), kwargs)
166+
this_page = self._api._get(url + 'page={}&query="{}"'.format(page, query),
167+
kwargs)
165168
this_page = this_page['results']
166169
tickets += this_page
167170
if len(this_page) < per_page or page == 10 or 'page' in kwargs:

0 commit comments

Comments
 (0)