Fixes issue where long line names were used on the timetable card (#415)

That broke parts of the UI if there were many of them, as that UI expects short names or numbers.

Author: nighthawk

Sources/TripKit/model/CoreData/Service+CoreDataClass.swift

@@ -54,11 +54,11 @@ public class Service: NSManagedObject {
     [number, lineName].compactMap { $0 }.joined(separator: " ")
   }
 
+  @available(*, deprecated, message: "Use `.numer` or `.lineName` as appropriate instead.")
   public var shortIdentifier: String? {
     number ?? lineName
   }
 
-  
 }
 
 // MARK: - Insertions

Sources/TripKit/model/CoreData/StopVisits+CoreDataClass.swift

@@ -75,11 +75,7 @@ extension StopVisits {
 
   /// :nodoc:
   public var smsString: String? {
-    guard let serviceId = service.shortIdentifier else {
-      return nil
-    }
-    
-    var output = serviceId
+    var output = service.title
 
     switch timing {
     case .timetabled(let arrival, let departure):
@@ -304,15 +300,15 @@ extension StopVisits: TKRealTimeUpdatable {
         let departureTime = TKStyleManager.timeString(departure, for: timeZone)
         let format = NSLocalizedString("I'll take a %@ at %@ from %@.", tableName: "TripKit", bundle: .tripKit, comment: "Indication of an activity. (old key: ActivityIndication)")
         return String(format: format,
-                      service.shortIdentifier ?? "",
+                      service.title,
                       departureTime,
                       stop.name ?? stop.stopCode
         )
 
       } else {
         let format = NSLocalizedString("I'll take a %@ from %@.", tableName: "TripKit", bundle: .tripKit, comment: "Indication of an activity.")
         return String(format: format,
-                      service.shortIdentifier ?? "",
+                      service.title,
                       stop.name ?? stop.stopCode
         )
       }

Sources/TripKitUI/cards/TKUITimetableCard+Content.swift

@@ -33,7 +33,7 @@ extension TKUIDepartureCellContent {
       imageIsTemplate: service.modeImageIsTemplate,
       imageTintColor: TKUICustomization.shared.colorCodeTransitIcons ? serviceColor : nil,
       modeName: service.modeTitle ?? "",
-      serviceShortName: service.shortIdentifier,
+      serviceShortName: service.number,
       serviceColor: serviceColor,
       serviceIsCanceled: service.isCanceled,
       serviceOperatorName: TKUITimetableCard.config.showOperatorNames ? service.operatorName : nil,

Sources/TripKitUI/view model/TKUITimetableViewModel+Content.swift

@@ -159,7 +159,7 @@ extension TKUITimetableViewModel {
   static func extractLines(from visits: [StopVisits]) -> [TKUITimetableAccessoryView.Line] {
     var lines: Set<TKUITimetableAccessoryView.Line> = []
     for visit in visits {
-      guard let text = visit.service.shortIdentifier else { continue }
+      guard let text = visit.service.number else { continue }
       let line = TKUITimetableAccessoryView.Line(text: text, color: visit.service.color)
       lines.insert(line)
     }