Merge pull request #81 from skellock/up-coverage

Adds full coverage.

Author: skellock

src/main/main-window/load-url.test.ts

@@ -0,0 +1,16 @@
+import { test } from 'ava'
+import { stub } from 'sinon'
+import { loadURL } from './load-url'
+
+test('loads from storybook', t => {
+  const loadStub = stub()
+  loadURL({ loadURL: loadStub } as any, 'a', true)
+  t.true(loadStub.calledWith('http://localhost:6006'))
+})
+
+test('loads from electron', t => {
+  const loadStub = stub()
+  loadURL({ loadURL: loadStub } as any, 'a', false)
+
+  t.true(loadStub.calledWith('file:///a/out/index.html'))
+})

src/main/main-window/main-window.test.ts

@@ -4,12 +4,31 @@ import { stub } from 'sinon'
 import { electron, BrowserWindow } from '../test/mock-electron'
 import { WindowStateManager } from '../test/mock-window-state-manager'
 
-test.beforeEach(() => mockery.enable({ warnOnUnregistered: false }))
-test.afterEach(() => {
+test.beforeEach(() => {
+  mockery.enable({ warnOnUnregistered: false })
+})
+test.afterEach.always(() => {
   mockery.deregisterAll()
   mockery.disable()
 })
 
+test('mocks have coverage :(', t => {
+  const win = new WindowStateManager()
+  t.is(win.x, 1)
+  t.is(win.y, 2)
+  t.is(win.width, 3)
+  t.is(win.height, 4)
+  t.is(win.maximized, true)
+  t.is(win.saveState({}), undefined)
+
+  const bw = new BrowserWindow()
+  t.is(bw.getSize(), undefined)
+  t.is(bw.loadURL(), undefined)
+  t.is(bw.maximize(), undefined)
+  t.is(bw.show(), undefined)
+  t.is(bw.focus(), undefined)
+})
+
 test('reads from window state', t => {
   // two step process for the getters :(
   const width = stub()
@@ -41,10 +60,26 @@ test('maximizes if told by the window state manager', t => {
 
   mockery.registerMock('electron-window-state-manager', WindowStateManager)
   mockery.registerMock('electron', electron)
+  const maximize = stub(BrowserWindow.prototype, 'maximize')
+  require('./main-window').createMainWindow(__dirname)
+  maximize.restore()
+
+  t.true(maximized.calledOnce)
+  t.true(maximize.calledOnce)
+})
+
+test('does not maximize unless told by the window state manager', t => {
+  const maximized = stub().returns(false)
+  stub(WindowStateManager.prototype, 'maximized').get(maximized)
 
+  mockery.registerMock('electron-window-state-manager', WindowStateManager)
+  mockery.registerMock('electron', electron)
+  const maximize = stub(BrowserWindow.prototype, 'maximize')
   require('./main-window').createMainWindow(__dirname)
+  maximize.restore()
 
   t.true(maximized.calledOnce)
+  t.true(maximize.notCalled)
 })
 
 test('saves window state', t => {
@@ -60,3 +95,20 @@ test('saves window state', t => {
 
   t.is(saveState.callCount, 3)
 })
+
+test.cb('show the window after we finish loading + delay', t => {
+  mockery.registerMock('electron-window-state-manager', WindowStateManager)
+  mockery.registerMock('electron', electron)
+
+  const window: BrowserWindow = require('./main-window').createMainWindow(__dirname, 1)
+  const showStub = stub(window, 'show')
+  const focusStub = stub(window, 'focus')
+
+  window.webContents.emit('did-finish-load')
+
+  setTimeout(() => {
+    t.true(showStub.calledOnce)
+    t.true(focusStub.calledOnce)
+    t.end()
+  }, 2)
+})

src/main/main-window/main-window.ts

@@ -9,9 +9,10 @@ const DIMENSIONS = { width: 600, height: 500, minWidth: 450, minHeight: 450 }
  * Creates the main window.
  *
  * @param appPath The path to the bundle root.
+ * @param showDelay How long in ms before showing the window after the renderer is ready.
  * @return The main BrowserWindow.
  */
-export function createMainWindow(appPath: string) {
+export function createMainWindow(appPath: string, showDelay: number = 100) {
   // persistent window state manager
   const windowState = new WindowStateManager('main', {
     defaultWidth: DIMENSIONS.width,
@@ -58,7 +59,7 @@ export function createMainWindow(appPath: string) {
     setTimeout(() => {
       window.show()
       window.focus()
-    }, 100)
+    }, showDelay)
   })
 
   return window

src/main/main.ts

@@ -31,7 +31,6 @@ app.on('ready', () => {
     })
 
     ipcMain.on('storybook-toggle', () => {
-      log.info('toggle')
       showStorybook = !showStorybook
       loadURL(window, appPath, showStorybook)
     })

src/main/menu/shared-menu.ts

@@ -1,4 +1,3 @@
-import * as log from 'electron-log'
 import { shell, ipcMain } from 'electron'
 
 export function createSharedMenuItems(window: Electron.BrowserWindow) {
@@ -19,7 +18,6 @@ export function createSharedMenuItems(window: Electron.BrowserWindow) {
   const storybook: Electron.MenuItemConstructorOptions = {
     label: 'Toggle Storybook',
     click() {
-      log.info('gonna send')
       ipcMain.emit('storybook-toggle')
     },
   }

src/main/test/mock-electron.ts

@@ -11,6 +11,8 @@ export class BrowserWindow extends EventEmitter {
   getSize() {}
   loadURL() {}
   maximize() {}
+  show() {}
+  focus() {}
 }
 
 /**

src/renderer/platform/components/centered-content/centered-content.test.tsx

@@ -0,0 +1,13 @@
+import * as React from 'react'
+import { test } from 'ava'
+import { create } from 'react-test-renderer'
+import { CenteredContent } from './centered-content'
+
+test('has children', t => {
+  const c = (
+    <CenteredContent>
+      <p>hi</p>
+    </CenteredContent>
+  )
+  t.snapshot(create(c).toJSON())
+})

src/renderer/platform/components/enter-animation/enter-animation.test.tsx

@@ -0,0 +1,22 @@
+import * as React from 'react'
+import { test } from 'ava'
+import { create } from 'react-test-renderer'
+import { EnterAnimation } from './enter-animation'
+
+test('grow', t => {
+  const c = (
+    <EnterAnimation animation='grow'>
+      <p>hi</p>
+    </EnterAnimation>
+  )
+  t.snapshot(create(c).toJSON())
+})
+
+test('slide', t => {
+  const c = (
+    <EnterAnimation animation='slide'>
+      <p>hi</p>
+    </EnterAnimation>
+  )
+  t.snapshot(create(c).toJSON())
+})

src/renderer/platform/components/enter-animation/enter-animation.tsx

@@ -51,7 +51,7 @@ export class EnterAnimation extends React.PureComponent<EnterAnimationProps, Ent
         break
     }
 
-    const transition = `transform ${speed || DEFAULT_SPEED}ms ${delay || DEFAULT_DELAY}ms`
+    const transition = `transform ${speed}ms ${delay}ms`
 
     // style props
     const starting = css(cssProps({ transform, transition }))

src/renderer/platform/components/scrollable-content/scrollable-content.test.tsx

@@ -0,0 +1,13 @@
+import * as React from 'react'
+import { test } from 'ava'
+import { create } from 'react-test-renderer'
+import { ScrollableContent } from './scrollable-content'
+
+test('has children', t => {
+  const c = (
+    <ScrollableContent>
+      <p>hi</p>
+    </ScrollableContent>
+  )
+  t.snapshot(create(c).toJSON())
+})