Skip to content

Commit a8c74fe

Browse files
committed
added some feedback fixes from mardown rewords to permission LeastPrivileg practices
1 parent ea6c256 commit a8c74fe

File tree

7 files changed

+10
-71
lines changed

7 files changed

+10
-71
lines changed

.github/steps/1-create-a-pr.md

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,3 @@
1-
<!--
2-
<<< Author notes: Step 1 >>>
3-
Choose 3-5 steps for your course.
4-
The first step is always the hardest, so pick something easy!
5-
Link to docs.github.com for further explanations.
6-
Encourage users to open new tabs for steps!
7-
-->
8-
91
## Step 1: Create a pull request
102

113
_Welcome to "Managing Merge Conflicts"! :wave:_

.github/steps/2-resolve-a-merge-conflict.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
<!--
2-
<<< Author notes: Step 2 >>>
3-
Start this step by acknowledging the previous step.
4-
Define terms and link to docs.github.com.
5-
-->
6-
71
## Step 2: Resolve a merge conflict
82

93
_Good start! Now let's look deeper at a merge conflict! :mag:_

.github/steps/3-create-your-own-conflict.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
<!--
2-
<<< Author notes: Step 3 >>>
3-
Start this step by acknowledging the previous step.
4-
Define terms and link to docs.github.com.
5-
-->
6-
71
## Step 3: Create your own conflict
82

93
_Good job! You've solved a merge conflict! :tada:_

.github/steps/4-merge-your-pull-request.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,3 @@
1-
<!--
2-
<<< Author notes: Step 4 >>>
3-
Start this step by acknowledging the previous step.
4-
Define terms and link to docs.github.com.
5-
-->
6-
71
## Step 4: Merge your pull request
82

93
_Almost there! :heart:_

.github/steps/X-finish.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,6 @@
1-
<!--
2-
<<< Author notes: Finish >>>
3-
Review what we learned, ask for feedback, provide next steps.
4-
-->
5-
61
## Finish
72

8-
_Congratulations friend, you've completed this course!_
3+
_Congratulations friend, you've completed this exercise!_
94

105
<img src=https://octodex.github.com/images/benevocats.jpg alt=celebrate width=300 align=right>
116

@@ -17,8 +12,8 @@ Here's a recap of all the tasks you've accomplished in your repository:
1712

1813
### What's next?
1914

20-
- Make your own Markdown resume site with GitHub Pages! Learn how in our [GitHub Pages](https://github.com/skills/github-pages) course.
21-
- We'd love to hear what you thought of this course [in our discussion board](https://github.com/orgs/skills/discussions/categories/resolve-merge-conflicts).
22-
- [Take another GitHub Skills course](https://github.com/skills).
15+
- Make your own Markdown resume site with GitHub Pages! Learn how in our [GitHub Pages](https://github.com/skills/github-pages) exercise.
16+
- We'd love to hear what you thought of this exercise [in our discussion board](https://github.com/orgs/skills/discussions/categories/resolve-merge-conflicts).
17+
- [Take another GitHub Skills exercise](https://github.com/skills).
2318
- [Read the GitHub Getting Started docs](https://docs.github.com/en/get-started).
2419
- To find projects to contribute to, check out [GitHub Explore](https://github.com/explore).

.github/workflows/1-create-a-pr.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,8 @@ on:
44
pull_request_target:
55
branches: [main]
66
types: [opened]
7-
workflow_dispatch: {}
87

98
permissions:
10-
contents: write
11-
actions: write
129
issues: write
1310
pull-requests: write # Required for commenting or updating PR
1411

@@ -31,7 +28,7 @@ jobs:
3128
- name: Checkout the base branch (main)
3229
uses: actions/checkout@v4
3330
with:
34-
ref: main # Required because pull_request_target runs in the base branch context
31+
ref: main
3532

3633
- name: Get response templates
3734
uses: actions/checkout@v4

README.md

Lines changed: 5 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,7 @@
1-
<header>
2-
3-
<!--
4-
<<< Author notes: Course header >>>
5-
Include a 1280×640 image, course title in sentence case, and a concise description in emphasis.
6-
In your repository settings: enable template repository, add your 1280×640 social image, auto delete head branches.
7-
Add your open source license, GitHub uses MIT license.
8-
-->
9-
101
# Resolve merge conflicts
112

123
_Learn why conflicts happen and how to resolve them._
134

14-
</header>
15-
16-
<!--
17-
<<< Author notes: Course start >>>
18-
Include start button, a note about Actions minutes,
19-
and tell the learner why they should take the course.
20-
-->
21-
225
## Welcome
236

247
Merge conflicts happen when two people make changes to the same file on GitHub—a common occurrence when you’re working with others. While resolving differences might involve some discussion, merge conflicts don’t have to be scary. This course guides you through the steps to finding the best merge conflict solution, so your team can keep building.
@@ -48,27 +31,17 @@ Simply copy the exercise to your account, then give your favorite Octocat (Mona)
4831
When copying the exercise, we recommend the following settings:
4932

5033
- For owner, choose your personal account or an organization to host the repository.
51-
- We recommend creating a public repository, as private repositories will [use Actions minutes](https://docs.github.com/en/billing/managing-billing-for-github-actions/about-billing-for-github-actions).
5234

53-
If the exercise isn't ready in 20 seconds:
35+
- We recommend creating a public repository, since private repositories will use Actions minutes.
5436

55-
1. After your new repository is created, wait about 20 seconds, then refresh the page.
56-
2. Follow the step-by-step instructions in the issue created in your repository.
57-
3. If the page doesn't refresh automatically, please check the [Actions](../../actions) tab.
58-
- Check to see if a job is running. Sometimes it simply takes a bit longer.
59-
- If the page shows a failed job, please submit an issue. Nice, you found a bug! 🐛
37+
If the exercise isn't ready in 20 seconds, please check the [Actions](../../actions) tab.
6038

61-
</details>
39+
- Check to see if a job is running. Sometimes it simply takes a bit longer.
6240

63-
<footer>
41+
- If the page shows a failed job, please submit an issue. Nice, you found a bug! 🐛
6442

65-
<!--
66-
<<< Author notes: Footer >>>
67-
Add a link to get support, GitHub status page, code of conduct, license link.
68-
-->
43+
</details>
6944

7045
---
7146

7247
&copy; 2025 GitHub &bull; [Code of Conduct](https://www.contributor-covenant.org/version/2/1/code_of_conduct/code_of_conduct.md) &bull; [MIT License](https://gh.io/mit)
73-
74-
</footer>

0 commit comments

Comments
 (0)