refactor: move the socials text from finish-exercise workflow to the exercise-finished template (#76)

Author: FidelusAleksander

.github/workflows/finish-exercise.yml

@@ -43,30 +43,6 @@ jobs:
           path: exercise-toolkit
           ref: ${{ env.EXERCISE_TOOLKIT_REF }}
 
-      - name: Encode socials text
-        id: encode-socials-text
-        uses: actions/github-script@v7
-        env:
-          EXERCISE_TITLE: ${{ inputs.exercise-title }}
-        with:
-          script: |
-            const repoUrl = `https://github.com/${context.repo.owner}/${context.repo.repo}`;
-            const exerciseTitle = process.env.EXERCISE_TITLE;
-
-            const firstLine = exerciseTitle && exerciseTitle.trim() !== ''
-              ? `I just completed the "${exerciseTitle}" GitHub Skills hands-on exercise! 🎉`
-              : `I just completed a GitHub Skills hands-on exercise! 🎉`;
-
-            const socialsText = `${firstLine}
-
-            ${repoUrl}
-
-            #GitHubSkills #OpenSource #GitHubLearn
-            `;
-
-            const encodedText = encodeURIComponent(socialsText);
-            core.setOutput('encoded-text', encodedText);
-
       - name: Build congratulations message from template
         id: build-new-readme
         uses: skills/action-text-variables@v3
@@ -75,7 +51,8 @@ jobs:
           template-vars: |
             login: ${{ github.actor }}
             issue_url: ${{ inputs.issue-url }}
-            encoded_socials_text: ${{ steps.encode-socials-text.outputs.encoded-text }}
+            exercise_title: ${{ inputs.exercise-title }}
+            repository_url: https://github.com/${{ github.repository }}
 
       - name: Overwrite README
         env:

markdown-templates/readme/exercise-finished.md

@@ -1,3 +1,14 @@
+{% set socials_text -%}
+{%- if exercise_title -%}
+I just completed the "{{ exercise_title }}" GitHub Skills hands-on exercise! 🎉
+{%- else -%}
+I just completed a GitHub Skills hands-on exercise! 🎉
+{%- endif %}
+
+{{ repository_url }}
+
+#GitHubSkills #OpenSource #GitHubLearn
+{%- endset -%}
 
 <div align="center">
 
@@ -11,20 +22,21 @@
 
 **Show off your new skills and inspire others!**
 
-<a href="https://twitter.com/intent/tweet?text={{ encoded_socials_text }}" target="_blank" rel="noopener noreferrer">
+<a href="https://twitter.com/intent/tweet?text={{ socials_text | urlencode }}" target="_blank" rel="noopener noreferrer">
   <img src="https://img.shields.io/badge/Share%20on%20X-1da1f2?style=for-the-badge&logo=x&logoColor=white" alt="Share on X" />
 </a>
-<a href="https://bsky.app/intent/compose?text={{ encoded_socials_text }}" target="_blank" rel="noopener noreferrer">
+<a href="https://bsky.app/intent/compose?text={{ socials_text | urlencode }}" target="_blank" rel="noopener noreferrer">
   <img src="https://img.shields.io/badge/Share%20on%20Bluesky-0085ff?style=for-the-badge&logo=bluesky&logoColor=white" alt="Share on Bluesky" />
 </a>
-<a href="https://www.linkedin.com/feed/?shareActive=true&text={{ encoded_socials_text }}" target="_blank" rel="noopener noreferrer">
+<a href="https://www.linkedin.com/feed/?shareActive=true&text={{ socials_text | urlencode }}" target="_blank" rel="noopener noreferrer">
   <img src="https://img.shields.io/badge/Share%20on%20LinkedIn-0077b5?style=for-the-badge&logo=linkedin&logoColor=white" alt="Share on LinkedIn" />
 </a>
 
 ### 🎯 What's Next?
+
 **Keep the momentum going!**
 
-[![](https://img.shields.io/badge/Return%20to%20Exercise-%E2%86%92-1f883d?style=for-the-badge&logo=github&labelColor=197935)]({{{ issue_url }}})
+[![](https://img.shields.io/badge/Return%20to%20Exercise-%E2%86%92-1f883d?style=for-the-badge&logo=github&labelColor=197935)]({{ issue_url }})
 [![GitHub Skills](https://img.shields.io/badge/Explore%20GitHub%20Skills-000000?style=for-the-badge&logo=github&logoColor=white)](https://learn.github.com/skills))
 
 *There's no better way to learn than building things!* 🚀