Skip to content

Commit 133308d

Browse files
authored
Merge pull request #42 from skiptools/bridgemodules
Bridge remaining Firebase modules
2 parents 617b916 + 03211ea commit 133308d

File tree

8 files changed

+31
-3
lines changed

8 files changed

+31
-3
lines changed

Sources/SkipFirebaseAppCheck/Skip/skip.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Configuration file for https://skip.tools project
22
#
3+
skip:
4+
mode: 'transpiled'
5+
bridging: true
6+
37
# Kotlin dependencies and Gradle build options for this module can be configured here
48
build:
59
contents:

Sources/SkipFirebaseCrashlytics/Skip/skip.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Configuration file for https://skip.tools project
22
#
3+
skip:
4+
mode: 'transpiled'
5+
bridging: true
6+
37
# Kotlin dependencies and Gradle build options for this module can be configured here
48
build:
59
contents:

Sources/SkipFirebaseDatabase/Skip/skip.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Configuration file for https://skip.tools project
22
#
3+
skip:
4+
mode: 'transpiled'
5+
bridging: true
6+
37
# Kotlin dependencies and Gradle build options for this module can be configured here
48
build:
59
contents:

Sources/SkipFirebaseFunctions/SkipFirebaseFunctions.swift

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ public class HTTPSCallable: KotlinConverting<com.google.firebase.functions.Https
3939
self.platformValue = platformValue
4040
}
4141

42+
// SKIP @nooverride
4243
public override func kotlin(nocopy: Bool = false) -> com.google.firebase.functions.HttpsCallableReference {
4344
platformValue
4445
}
@@ -71,6 +72,7 @@ public class HTTPSCallableResult: KotlinConverting<com.google.firebase.functions
7172
self.platformValue = platformValue
7273
}
7374

75+
// SKIP @nooverride
7476
public override func kotlin(nocopy: Bool = false) -> com.google.firebase.functions.HttpsCallableResult {
7577
platformValue
7678
}

Sources/SkipFirebaseInstallations/Skip/skip.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Configuration file for https://skip.tools project
22
#
3+
skip:
4+
mode: 'transpiled'
5+
bridging: true
6+
37
# Kotlin dependencies and Gradle build options for this module can be configured here
48
build:
59
contents:

Sources/SkipFirebaseRemoteConfig/Skip/skip.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Configuration file for https://skip.tools project
22
#
3+
skip:
4+
mode: 'transpiled'
5+
bridging: true
6+
37
# Kotlin dependencies and Gradle build options for this module can be configured here
48
build:
59
contents:

Sources/SkipFirebaseStorage/Skip/skip.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Configuration file for https://skip.tools project
22
#
3+
skip:
4+
mode: 'transpiled'
5+
bridging: true
6+
37
# Kotlin dependencies and Gradle build options for this module can be configured here
48
build:
59
contents:

Sources/SkipFirebaseStorage/SkipFirebaseStorage.swift

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ public class StorageMetadata: KotlinConverting<com.google.firebase.storage.Stora
7070
self.platformValue = platformValue
7171
}
7272

73+
// SKIP @nooverride
7374
public override func kotlin(nocopy: Bool = false) -> com.google.firebase.storage.StorageMetadata {
7475
platformValue
7576
}
@@ -187,6 +188,7 @@ public class StorageReference: KotlinConverting<com.google.firebase.storage.Stor
187188
self.platformValue = platformValue
188189
}
189190

191+
// SKIP @nooverride
190192
public override func kotlin(nocopy: Bool = false) -> com.google.firebase.storage.StorageReference {
191193
platformValue
192194
}
@@ -247,7 +249,7 @@ public class StorageReference: KotlinConverting<com.google.firebase.storage.Stor
247249
}
248250

249251
/// Error is `StorageException`
250-
public func putFile(from fileURL: URL, metadata: StorageMetadata? = nil, completion: (_: StorageMetadata?, _: Error?) -> Void = { _, _ in }) -> StorageUploadTask {
252+
public func putFile(from fileURL: URL, metadata: StorageMetadata? = nil, completion: @escaping (_: StorageMetadata?, _: Error?) -> Void = { _, _ in }) -> StorageUploadTask {
251253
let fileURI: android.net.Uri = android.net.Uri.parse(fileURL.kotlin().toString())
252254

253255
let uploadTask = metadata == nil ? platformValue.putFile(fileURI) : platformValue.putFile(fileURI, metadata!.platformValue, nil)
@@ -279,7 +281,7 @@ public class StorageReference: KotlinConverting<com.google.firebase.storage.Stor
279281
}
280282

281283
/// Error is `StorageException`
282-
public func putData(_ uploadData: Data, metadata: StorageMetadata? = nil, completion: (_: StorageMetadata?, _: Error?) -> Void) -> StorageUploadTask {
284+
public func putData(_ uploadData: Data, metadata: StorageMetadata? = nil, completion: @escaping (_: StorageMetadata?, _: Error?) -> Void) -> StorageUploadTask {
283285
// putBytes(bytes, metadata) is @NonNull, so we need to use different methods for null vs. non-null metadata parameter
284286
let uploadTask = metadata == nil ? platformValue.putBytes(uploadData.platformValue) : platformValue.putBytes(uploadData.platformValue, metadata!.platformValue)
285287

@@ -332,7 +334,7 @@ public class StorageReference: KotlinConverting<com.google.firebase.storage.Stor
332334
}
333335

334336
/// Error is `StorageException`/`IndexOutOfBoundsException`
335-
public func getData(maxSize: Int64, completion: (_: Data?, _: Error?) -> Void) -> StorageDownloadTask {
337+
public func getData(maxSize: Int64, completion: @escaping (_: Data?, _: Error?) -> Void) -> StorageDownloadTask {
336338

337339
let downloadTask = platformValue.getBytes(maxSize)
338340
Task {

0 commit comments

Comments
 (0)