Skip to content

Commit 9486fef

Browse files
committed
Modernize project to match skip-generated template
1 parent dc58ab5 commit 9486fef

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

.gitignore

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,16 +60,9 @@ Package.resolved
6060
Carthage/Build/
6161

6262
# fastlane
63-
#
64-
# It is recommended to not store the screenshots in the git repo.
65-
# Instead, use fastlane to re-generate the screenshots whenever they are needed.
66-
# For more information about the recommended setup visit:
67-
# https://docs.fastlane.tools/best-practices/source-control/#source-control
6863

6964
**/fastlane/apikey.json
7065
**/fastlane/report.xml
7166
**/fastlane/README.md
7267
**/fastlane/Preview.html
73-
**/fastlane/screenshots/**/*.png
74-
**/fastlane/metadata/android/*/images/**/*.png
7568
**/fastlane/test_output

Android/app/build.gradle.kts

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,19 @@ plugins {
1010
skip {
1111
}
1212

13+
kotlin {
14+
compilerOptions {
15+
jvmTarget = org.jetbrains.kotlin.gradle.dsl.JvmTarget.fromTarget(libs.versions.jvm.get().toString())
16+
}
17+
}
18+
1319
android {
1420
namespace = group as String
1521
compileSdk = libs.versions.android.sdk.compile.get().toInt()
1622
compileOptions {
1723
sourceCompatibility = JavaVersion.toVersion(libs.versions.jvm.get())
1824
targetCompatibility = JavaVersion.toVersion(libs.versions.jvm.get())
1925
}
20-
kotlinOptions {
21-
jvmTarget = libs.versions.jvm.get().toString()
22-
}
2326
packaging {
2427
jniLibs {
2528
keepDebugSymbols.add("**/*.so")
@@ -41,16 +44,23 @@ android {
4144
}
4245

4346
// default signing configuration tries to load from keystore.properties
47+
// see: https://skip.tools/docs/deployment/#export-signing
4448
signingConfigs {
4549
val keystorePropertiesFile = file("keystore.properties")
46-
if (keystorePropertiesFile.isFile) {
47-
create("release") {
50+
create("release") {
51+
if (keystorePropertiesFile.isFile) {
4852
val keystoreProperties = Properties()
4953
keystoreProperties.load(keystorePropertiesFile.inputStream())
5054
keyAlias = keystoreProperties.getProperty("keyAlias")
5155
keyPassword = keystoreProperties.getProperty("keyPassword")
5256
storeFile = file(keystoreProperties.getProperty("storeFile"))
5357
storePassword = keystoreProperties.getProperty("storePassword")
58+
} else {
59+
// when there is no keystore.properties file, fall back to signing with debug config
60+
keyAlias = signingConfigs.getByName("debug").keyAlias
61+
keyPassword = signingConfigs.getByName("debug").keyPassword
62+
storeFile = signingConfigs.getByName("debug").storeFile
63+
storePassword = signingConfigs.getByName("debug").storePassword
5464
}
5565
}
5666
}

Android/app/src/main/kotlin/app/droid/Main.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ open class MainActivity: AppCompatActivity {
7070
//ActivityCompat.requestPermissions(self, permissions.toTypedArray(), requestTag)
7171
}
7272

73-
override fun onSaveInstanceState(bundle: android.os.Bundle): Unit = super.onSaveInstanceState(bundle)
73+
override fun onSaveInstanceState(outState: android.os.Bundle): Unit = super.onSaveInstanceState(outState)
7474

7575
override fun onRestoreInstanceState(bundle: android.os.Bundle) {
7676
// Usually you restore your state in onCreate(). It is possible to restore it in onRestoreInstanceState() as well, but not very common. (onRestoreInstanceState() is called after onStart(), whereas onCreate() is called before onStart().

0 commit comments

Comments
 (0)