Apply ruff/flake8-bugbear rule B015

B015 Pointless comparison.

Author: DimitriPapadopoulos

skrub/_data_ops/tests/test_errors.py

@@ -41,7 +41,7 @@ def test_contains():
     with pytest.raises(
         TypeError, match=".*it is not possible to eagerly perform membership tests"
     ):
-        2 in a
+        2 in a  # noqa: B015
 
 
 def test_setitem():

skrub/_data_ops/tests/test_estimators.py

@@ -190,7 +190,7 @@ def test_randomized_search(data_op, data, n_jobs):
 def test_grid_search(data_op, data, n_jobs):
     search = data_op.skb.make_grid_search(n_jobs=n_jobs)
     search.fit(data)
-    search.results_["mean_test_score"].iloc[0] == pytest.approx(0.84, abs=0.05)
+    assert search.results_["mean_test_score"].iloc[0] == pytest.approx(0.84, abs=0.05)
     assert search.decision_function(data).shape == (100,)
     train_score = search.score(data)
     assert train_score == pytest.approx(0.94)

skrub/tests/test_agg_joiner.py

@@ -408,7 +408,7 @@ def test_agg_joiner_default_cols(main_table):
         aux_table=main_table, operations="mode", key=["movieId", "userId"]
     )
     agg_joiner.fit(main_table)
-    agg_joiner._cols == ["rating", "genre"]
+    assert agg_joiner._cols == ["rating", "genre"]
 
 
 def test_agg_joiner_correct_cols(df_module, main_table):
@@ -422,7 +422,7 @@ def test_agg_joiner_correct_cols(df_module, main_table):
         cols=["rating"],
     )
     agg_joiner.fit(main_table)
-    agg_joiner._cols == ["rating"]
+    assert agg_joiner._cols == ["rating"]
 
 
 def test_agg_joiner_wrong_cols(main_table):
@@ -662,7 +662,7 @@ def test_agg_target_multiple_main_key(df_module, main_table, y_df):
         operations="max",
     )
     main_transformed = agg_target.fit_transform(main_table, y_df)
-    sbd.column_names(main_transformed) == [
+    assert sbd.column_names(main_transformed) == [
         "userId",
         "movieId",
         "rating",

skrub/tests/test_config.py

@@ -86,7 +86,7 @@ def test_max_plot_columns(simple_df):
     # repr_html.
     with config_context(use_table_report=True):
         with config_context(max_plot_columns=3):
-            "Plotting was skipped" in simple_df._repr_html_()
+            assert "Plotting was skipped" in simple_df._repr_html_()
 
 
 def test_enable_subsampling(simple_df):

skrub/tests/test_multi_agg_joiner.py

@@ -341,7 +341,10 @@ def test_default_cols(main_table, df_module):
         keys=[["userId", "movieId"], ["userId"]],
     )
     multi_agg_joiner.fit(main_table)
-    multi_agg_joiner._cols == [["rating", "genre"], ["movieId", "rating", "genre"]]
+    assert multi_agg_joiner._cols == [
+        ["rating", "genre"],
+        ["movieId", "rating", "genre"],
+    ]
 
 
 def test_correct_cols(main_table, df_module):