Adds MaxAge cache header to ImageMetaData to prevent unnecessary meta data lookups through http

skttl · skttl · commit 3427f18021f7 · 2024-08-28T11:41:36.000+02:00
diff --git a/src/ImageSharpCommunity.Providers.Remote/RemoteImageResolver.cs b/src/ImageSharpCommunity.Providers.Remote/RemoteImageResolver.cs
@@ -36,7 +36,12 @@ public async Task<ImageMetadata> GetMetaDataAsync()
             _logger.LogDebug("LastModified header missing from {Url}", _url);
         }
 
-        return new ImageMetadata(response.Content.Headers.LastModified.GetValueOrDefault().UtcDateTime, response.Content.Headers.ContentLength.GetValueOrDefault());
+        if (response.Headers.CacheControl?.MaxAge is null)
+        {
+            _logger.LogDebug("MaxAge header is null from {Url}", _url);
+        }
+
+        return new ImageMetadata(response.Content.Headers.LastModified.GetValueOrDefault().UtcDateTime, (response.Headers.CacheControl?.MaxAge).GetValueOrDefault(), response.Content.Headers.ContentLength.GetValueOrDefault());
     }
 
     public async Task<Stream> OpenReadAsync()

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,12 @@ public async Task<ImageMetadata> GetMetaDataAsync()`
`36`	`36`	`_logger.LogDebug("LastModified header missing from {Url}", _url);`
`37`	`37`	`}`
`38`	`38`
`39`		`- return new ImageMetadata(response.Content.Headers.LastModified.GetValueOrDefault().UtcDateTime, response.Content.Headers.ContentLength.GetValueOrDefault());`
	`39`	`+ if (response.Headers.CacheControl?.MaxAge is null)`
	`40`	`+ {`
	`41`	`+ _logger.LogDebug("MaxAge header is null from {Url}", _url);`
	`42`	`+ }`
	`43`	`+`
	`44`	`+ return new ImageMetadata(response.Content.Headers.LastModified.GetValueOrDefault().UtcDateTime, (response.Headers.CacheControl?.MaxAge).GetValueOrDefault(), response.Content.Headers.ContentLength.GetValueOrDefault());`
`40`	`45`	`}`
`41`	`46`
`42`	`47`	`public async Task<Stream> OpenReadAsync()`