Cleanup threw a js error when closing the dialog before selecting doctype

skttl · skttl · commit 074faa564efa · 2020-04-14T21:08:06.000+02:00
Check for the existence of $scope.model.node before deleting the blueprint
diff --git a/src/Our.Umbraco.DocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Js/doctypegrideditor.controllers.js b/src/Our.Umbraco.DocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Js/doctypegrideditor.controllers.js
@@ -244,7 +244,7 @@ angular.module("umbraco").controller("Our.Umbraco.DocTypeGridEditor.Dialogs.DocT
             vm.blueprintConfig = blueprintConfig;
 
             function cleanup() {
-                if ($scope.model.node.id > 0){
+                if ($scope.model.node && $scope.model.node.id > 0){
                     // delete any temporary blueprints used for validation
                     contentResource.deleteBlueprint($scope.model.node.id);
                 }

Original file line number	Diff line number	Diff line change
`@@ -244,7 +244,7 @@ angular.module("umbraco").controller("Our.Umbraco.DocTypeGridEditor.Dialogs.DocT`
`244`	`244`	`vm.blueprintConfig = blueprintConfig;`
`245`	`245`
`246`	`246`	`function cleanup() {`
`247`		`- if ($scope.model.node.id > 0){`
	`247`	`+ if ($scope.model.node && $scope.model.node.id > 0){`
`248`	`248`	`// delete any temporary blueprints used for validation`
`249`	`249`	`contentResource.deleteBlueprint($scope.model.node.id);`
`250`	`250`	`}`