Skip to content
This repository was archived by the owner on Feb 10, 2024. It is now read-only.

Commit 6d25786

Browse files
committed
housecleaning
1 parent 0e034a7 commit 6d25786

File tree

3 files changed

+0
-24
lines changed

3 files changed

+0
-24
lines changed

src/Our.Umbraco.DocTypeGridEditor/Models/DetachedPublishedProperty.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ public DetachedPublishedProperty(PublishedPropertyType propertyType, object valu
2525

2626
_rawValue = value;
2727

28-
// TODO: FIXME!
2928
_sourceValue = new Lazy<object>(() => _propertyType.ConvertSourceToInter(null, _rawValue, _isPreview));
3029
_objectValue = new Lazy<object>(() => _propertyType.ConvertInterToObject(null, PropertyEditors.PropertyCacheLevel.None, _sourceValue.Value, _isPreview));
3130
_xpathValue = new Lazy<object>(() => _propertyType.ConvertInterToXPath(null, PropertyEditors.PropertyCacheLevel.None, _sourceValue.Value, _isPreview));

src/Our.Umbraco.DocTypeGridEditor/Models/UnpublishedContent.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,6 @@ private Dictionary<string, IPublishedProperty> MapProperties(ServiceContext serv
138138
Current.PropertyEditors.TryGet(propertyType.DataType.EditorAlias, out var editor);
139139
if (editor != null)
140140
{
141-
// TODO: FIXME!
142141
value = editor.GetValueEditor().ConvertDbToString(property.PropertyType, value, services.DataTypeService);
143142
}
144143
}

src/Our.Umbraco.DocTypeGridEditor/Web/Controllers/DocTypeGridEditorApiController.cs

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,6 @@ public object GetDataTypePreValues(string dtdId)
126126
return null;
127127

128128
// Convert to editor config
129-
//var preValue = Services.DataTypeService.GetPreValuesCollectionByDataTypeId(dtd.Id);
130-
//var propEditor = PropertyEditorResolver.Current.GetByAlias(dtd.PropertyEditorAlias);
131-
//return propEditor.PreValueEditor.ConvertDbToEditor(propEditor.DefaultPreValues, preValue);
132-
133-
// TODO: FIXME! This is not the data we were expecting, not sure what we were actually expecting and why :)
134129
var dataType = Current.Services.DataTypeService.GetDataType(dtd.Id);
135130
var propEditor = dataType.Editor;
136131
var content = propEditor.GetValueEditor().ConvertDbToString(new PropertyType(dataType), dataType.Configuration, Current.Services.DataTypeService);
@@ -154,23 +149,6 @@ public HttpResponseMessage GetPreviewMarkup([FromBody] PreviewData data, [FromUr
154149
}
155150
}
156151

157-
// NOTE: The previous previewer had a content node associated with the request,
158-
// meaning that an implementation may have used this to traverse the content-tree.
159-
// In order to maintain backward-compatibility, we must ensure the PublishedContentRequest context.
160-
161-
// TODO: Do we still need this hack?
162-
//if (UmbracoContext.PublishedContentRequest == null)
163-
//{
164-
// UmbracoContext.PublishedContentRequest = new PublishedContentRequest(
165-
// Request.RequestUri,
166-
// UmbracoContext.RoutingContext,
167-
// UmbracoConfig.For.UmbracoSettings().WebRouting,
168-
// null)
169-
// {
170-
// PublishedContent = page
171-
// };
172-
//}
173-
174152
// Set the culture for the preview
175153
if (page != null)
176154
{

0 commit comments

Comments
 (0)