Skip to content
This repository was archived by the owner on Feb 10, 2024. It is now read-only.

Commit 8371a86

Browse files
authored
Merge pull request #167 from tompipe/166-dialogsize
Fix for #166 - New dialog "Size" property causes manifest validation to fail
2 parents 47c8f5d + d9ef295 commit 8371a86

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

docs/developers-guide.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ You can also add your editors using a package.manifest file in a folder in the `
5757
"allowedDocTypes": [...],
5858
"nameTemplate": "",
5959
"enablePreview": true,
60-
"size": "medium",
60+
"overlaySize": "medium",
6161
"viewPath": "/Views/Partials/Grid/Editors/DocTypeGridEditor/",
6262
"previewViewPath": "/Views/Partials/Grid/Editors/DocTypeGridEditor/Previews/",
6363
"previewCssFilePath": "",
@@ -86,8 +86,9 @@ The **Doc Type Grid Editor** supports 3 config options, all of which are optiona
8686
| AllowedDocTypes | String[] | An array of doc type aliases of which should be allowed to be selected in the grid editor. Strings can be REGEX patterns to allow matching groups of doc types in a single entry. e.g. "Widget$" will match all doc types with an alias ending in "Widget". However if a single doc type is matched, (aka **Single Doc Type Mode**), then doc type selection stage (in the DTGE panel) will be skipped. Note, your document type must be an Element type, in order to be usable in DTGE. |
8787
| NameTemplate | String | Allows using any of the doctype's property values in the name/label: {{propertyAlias}} |
8888
| EnablePreview | Boolean | Enables rendering a preview of the grid cell in the grid editor. |
89-
| Size | String | Define the size of the grid editor dialog. You can write `large`, `medium` or `small`. If no size is set, the grid editor dialog will be small. Note, the medium size requires a minimum Umbraco version of 8.3 |
90-
| LargeDialog | Boolean | (obsolete, use Size instead) Makes the editing dialog larger. Especially useful for grid editors with complex property editors. |
89+
| overlaySize | String | Define the size of the grid editor dialog. You can write `large`, `medium` or `small`. If no size is set, the grid editor dialog will be small. Note, the medium size requires a minimum Umbraco version of 8.3 |
90+
| LargeDialog | Boolean | (obsolete, use overlaySize instead) Makes the editing dialog larger. Especially useful for grid editors with complex property editors. |
91+
| size | string | (obsolete, use overlaySize instead)
9192
| ViewPath | String | Sets an alternative view path for where the **Doc Type Grid Editor** should look for views when rendering. Defaults to `~/Views/Partials/` |
9293
| PreviewViewPath | String | Sets an alternative view path for where the **Doc Type Grid Editor** should look for views when rendering previews in the backoffice |
9394
| ShowDocTypeSelectAsGrid | Boolean | Makes the content type selection dialog render a grid, in stead of the default list with descriptions |

src/Our.Umbraco.DocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Js/doctypegrideditor.controllers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
overlayOptions.allowedDocTypes = $scope.control.editor.config.allowedDocTypes || [];
8686
overlayOptions.showDocTypeSelectAsGrid = $scope.control.editor.config.showDocTypeSelectAsGrid === true;
8787
overlayOptions.nameTemplate = $scope.control.editor.config.nameTemplate;
88-
overlayOptions.size = $scope.control.editor.config.largeDialog ? null : $scope.control.editor.config.size || "small";
88+
overlayOptions.size = $scope.control.editor.config.largeDialog ? null : $scope.control.editor.config.overlaySize || "small";
8989

9090
overlayOptions.dialogData = {
9191
docTypeAlias: $scope.control.value.dtgeContentTypeAlias,

0 commit comments

Comments
 (0)