Skip to content

Deduplicate metrics created by loadAndRun #134

@danieljbingham

Description

@danieljbingham

Is your feature request related to a problem? Please describe.
We've been noticing logs similar to the below, logging constantly for different kafka metrics, reporting multiple values for the same attributes:

[otel.javaagent 2024-11-20 10:01:38:390 +0000] [prometheus-http-1-1] WARN io.opentelemetry.sdk.metrics.internal.state.AsynchronousMetricStorage - Instrument kafka.consumer.connection_close_rate has recorded multiple values for the same attributes: {client-id="recently-watched-ingest"}

This duplication is caused by loadAndRun creating 2 KafkaConsumers with identical client-ids. We validated this by updating the clientId for one of the consumers, and the warning logs disappeared.

Describe the solution you'd like
We should be able to specify different consumerSettings or clientIds per KafkaConsumer to avoid these clashes.

Describe alternatives you've considered

  • We could disable our own logs for this, but this would just hide the problem
  • Only one consumer could be used, but two are required for re-assigning offsets after the initial load

Additional context
loadAndRun method

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions