State Transition Improvements #800
Description
Is your feature request related to a problem? Please describe
Currently the state transition code uses the command pattern, this works well for the generic resource state management, however it fails to provide the required feedback needed to error reconciles. Instead all reconciles once they reach the state transition are considered to be successful even when they are setting the state of a resource to be failed.
This becomes an issue as it prevents us from retrying a reconciliation, which is a strategy we want to adopt as per #675 .
Describe the solution you would like
There needs to be some evaluation of the current state transition code and a plan made for the overhaul of this area of code, command pattern does seem to be sensible but it must provide the ability to discern errors and handle them as we expect in an operator and not just succeed on failing resources.
Describe alternative solutions you have considered
N/A
Additional context
The solution has been left deliberately vague as a placeholder issue that needs more design work.