性能优化

Author: user123

Services.App/MainWindow.xaml.cs

@@ -24,6 +24,8 @@ public sealed partial class MainWindow : Window
         private readonly LogManager _logManager;
         private AppWindow _appWindow;
         private bool _isRealExit = false;
+        private DispatcherTimer? _refreshTimer;
+        private bool _isLoadServicesRunning = false;
 
         public ObservableCollection<Service> Services { get; } = new();
 
@@ -61,11 +63,23 @@ public MainWindow()
             LoadServices();
             Title = "ServicesApp";
 
-            this.Closed += (s, e) => _serviceManager.Dispose();
+            this.Closed += OnWindowClosed;
 
-            var timer = new DispatcherTimer { Interval = TimeSpan.FromSeconds(2) };
-            timer.Tick += (s, e) => LoadServices(true);
-            timer.Start();
+            _refreshTimer = new DispatcherTimer { Interval = TimeSpan.FromSeconds(2) };
+            _refreshTimer.Tick += (s, e) => LoadServices(true);
+            _refreshTimer.Start();
+        }
+
+        private void OnWindowClosed(object sender, WindowEventArgs args)
+        {
+            _refreshTimer?.Stop();
+            _refreshTimer = null;
+            if (_serviceManager != null)
+            {
+                _serviceManager.ServiceUpdated -= OnServiceUpdated;
+                _serviceManager.Dispose();
+            }
+            TrayIcon?.Dispose();
         }
 
         private void InitializeTrayIcon()
@@ -136,6 +150,7 @@ public void ShowWindow()
             _appWindow.Show();
             _appWindow.MoveInZOrderAtTop();
             this.Activate();
+            LoadServices(); // Refresh immediately when showing
         }
 
         public void RealExit()
@@ -172,6 +187,12 @@ private void OnServiceUpdated(object? sender, Service service)
 
         private async void LoadServices(bool silent = false)
         {
+            if (_isLoadServicesRunning) return;
+
+            // Optimization: Do not refresh UI if window is hidden and this is an automated refresh
+            if (silent && _appWindow != null && !_appWindow.IsVisible) return;
+
+            _isLoadServicesRunning = true;
             try
             {
                 if (!silent) UpdateStatus("正在加载服务...");
@@ -205,6 +226,10 @@ private async void LoadServices(bool silent = false)
             {
                 if (!silent) UpdateStatus($"加载服务失败: {ex.Message}");
             }
+            finally
+            {
+                _isLoadServicesRunning = false;
+            }
         }
 
         private void OnRefreshClick(object sender, RoutedEventArgs e)

Services.Core/Services.Core.csproj

@@ -6,6 +6,7 @@
     <Nullable>enable</Nullable>
     <Platforms>x64</Platforms>
     <Platform>x64</Platform>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
 
   <ItemGroup>

Services.Core/Services/EmbeddedServiceWrapper.cs

@@ -59,10 +59,13 @@ protected override void OnStop()
             {
                 try
                 {
-                    _process.Kill();
+                    _process.Kill(true); // Kill entire process tree
                     _process.WaitForExit(5000);
                 }
-                catch { }
+                catch (Exception ex)
+                {
+                    WriteLog($"Error stopping process: {ex.Message}");
+                }
             }
 
             CloseLogWriter();

Services.Core/Services/LogManager.cs

@@ -44,15 +44,22 @@ public async Task<string> ReadLogAsync(string? logPath)
             try
             {
                 using (var stream = new FileStream(logPath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                using (var reader = new StreamReader(stream))
                 {
                     if (stream.Length > 100 * 1024)
                     {
                         stream.Seek(-100 * 1024, SeekOrigin.End);
-                        reader.ReadLine(); 
-                        return "... (旧日志已截断) ...\n" + await reader.ReadToEndAsync();
+                        // StreamReader buffers data, so we must seek BEFORE creating it.
+                        using (var reader = new StreamReader(stream))
+                        {
+                            await reader.ReadLineAsync(); // Discard partial line
+                            return "... (旧日志已截断) ...\n" + await reader.ReadToEndAsync();
+                        }
+                    }
+                    
+                    using (var reader = new StreamReader(stream))
+                    {
+                        return await reader.ReadToEndAsync();
                     }
-                    return await reader.ReadToEndAsync();
                 }
             }
             catch (Exception ex)
@@ -72,18 +79,24 @@ public void CleanupOldLogs(int retentionDays = DefaultRetentionDays)
 
                 foreach (var file in files)
                 {
-                    var fileInfo = new FileInfo(file);
-                    if (fileInfo.CreationTime < cutoffDate)
+                    try
                     {
-                        try
+                        var fileInfo = new FileInfo(file);
+                        if (fileInfo.CreationTime < cutoffDate)
                         {
                             fileInfo.Delete();
                         }
-                        catch { }
+                    }
+                    catch (Exception ex)
+                    {
+                        System.Diagnostics.Debug.WriteLine($"Failed to delete log {file}: {ex.Message}");
                     }
                 }
             }
-            catch { }
+            catch (Exception ex)
+            {
+                System.Diagnostics.Debug.WriteLine($"CleanupOldLogs failed: {ex.Message}");
+            }
         }
 
         public static int GetGlobalRetentionDays()

Services.Core/Services/ServiceMonitor.cs

@@ -89,30 +89,33 @@ public class ServiceStatusEventArgs : EventArgs
 
             try
             {
-                uint bytesNeeded;
-                IntPtr ptr = Marshal.AllocHGlobal(1024);
-                try
+                // Use stackalloc to avoid heap allocation for small buffer
+                Span<byte> buffer = stackalloc byte[1024];
+                unsafe
                 {
-                    if (QueryServiceStatusEx(_hService, 0, ptr, 1024, out bytesNeeded))
+                    fixed (byte* pBuffer = buffer)
                     {
-                        var status = Marshal.PtrToStructure<SERVICE_STATUS_PROCESS>(ptr);
-                         string statusStr = status.dwCurrentState switch
+                        uint bytesNeeded;
+                        if (QueryServiceStatusEx(_hService, 0, (IntPtr)pBuffer, 1024, out bytesNeeded))
                         {
-                            1 => "已停止",
-                            2 => "启动中",
-                            3 => "停止中",
-                            4 => "运行中",
-                            _ => "未知"
-                        };
-                        return (statusStr, (int)status.dwProcessId);
+                            var status = Marshal.PtrToStructure<SERVICE_STATUS_PROCESS>((IntPtr)pBuffer);
+                             string statusStr = status.dwCurrentState switch
+                            {
+                                1 => "已停止",
+                                2 => "启动中",
+                                3 => "停止中",
+                                4 => "运行中",
+                                _ => "未知"
+                            };
+                            return (statusStr, (int)status.dwProcessId);
+                        }
                     }
                 }
-                finally
-                {
-                    Marshal.FreeHGlobal(ptr);
-                }
             }
-            catch { }
+            catch (Exception ex)
+            {
+                System.Diagnostics.Debug.WriteLine($"GetCurrentStatus Failed: {ex.Message}");
+            }
             return ("未知", 0);
         }