Skip to content

Commit 69882ef

Browse files
authored
Merge pull request #1222 from hunchback/k8s-metadata-daemonset
k8s: fix daemonset metadata
2 parents 43c1d06 + 9437247 commit 69882ef

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

tests/k8s/daemonset.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ apiVersion: apps/v1
22
kind: DaemonSet
33
metadata:
44
name: skydive-test-daemonset
5-
namespace: kube-system
65
labels:
76
k8s-app: skydive-test-daemonset-fluentd-logging
87
spec:

tests/k8s_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ func TestK8sNamespaceNode(t *testing.T) {
183183
}
184184

185185
func TestK8sDaemonSetNode(t *testing.T) {
186-
testNodeCreationFromConfig(t, "daemonset", objName+"-daemonset")
186+
testNodeCreationFromConfig(t, "daemonset", objName+"-daemonset", "Labels", "DesiredNumberScheduled", "CurrentNumberScheduled", "NumberMisscheduled")
187187
}
188188

189189
func TestK8sNetworkPolicyNode(t *testing.T) {

topology/probes/k8s/daemonset.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,16 @@ type dsProbe struct {
4040
}
4141

4242
func dumpDaemonSet(ds *v1beta1.DaemonSet) string {
43-
return fmt.Sprintf("daemonset{Name: %s}", ds.GetName())
43+
return fmt.Sprintf("daemonset{Namespace: %s, Name: %s}", ds.Namespace, ds.Name)
4444
}
4545

4646
func (p *dsProbe) newMetadata(ds *v1beta1.DaemonSet) graph.Metadata {
47-
return newMetadata("daemonset", ds.Namespace, ds.GetName(), ds)
47+
m := newMetadata("daemonset", ds.Namespace, ds.Name, ds)
48+
m.SetFieldAndNormalize("Labels", ds.Labels)
49+
m.SetField("DesiredNumberScheduled", ds.Status.DesiredNumberScheduled)
50+
m.SetField("CurrentNumberScheduled", ds.Status.CurrentNumberScheduled)
51+
m.SetField("NumberMisscheduled", ds.Status.NumberMisscheduled)
52+
return m
4853
}
4954

5055
func dsUID(ds *v1beta1.DaemonSet) graph.Identifier {

0 commit comments

Comments
 (0)