update readme, extra tests

Author: 2lives

README.md

@@ -65,7 +65,7 @@ payload = {
   'profile_id': 2
 }
 
-api.create_job(job_id, payload=payload)
+api.update_job(job_id, payload=payload)
 ```
 
 For all payload options, consult the [API documentation](https://studio-docs.skylabtech.ai/#tag/job/operation/updateJobById).

skylab_studio/__init__.py

@@ -34,7 +34,10 @@ class api: #pylint: disable=invalid-name
     """
 
     # initialization
-    api_url = os.environ['SKYLAB_API_URL'] or 'https://studio.skylabtech.ai:443'
+    try:
+        api_url = os.environ['SKYLAB_API_URL']
+    except KeyError:
+        api_url = 'https://studio.skylabtech.ai:443'
 
     # this is not package version -> used to construct the request base url
     api_version = '1'
@@ -239,7 +242,8 @@ def list_photos(self):
     def get_upload_url(self, payload={"use_cache_upload": False}):
       return self._api_request('photos/upload_url', 'GET', payload=payload)
 
-    def create_photo(self, payload=None):
+    # todo privatize this method and test photo_upload
+    def _create_photo(self, payload=None):
         """ API call to create a photo """
         return self._api_request(
             'photos',
@@ -282,7 +286,7 @@ def upload_photo(self, photo_path, model, id):
                 headers = { 'X-Amz-Tagging': 'job=photo&api=true' }
 
         # Ask studio to create the photo record
-        photo_resp = self.create_photo(photo_data)
+        photo_resp = self._create_photo(photo_data)
 
         if photo_resp.status_code != 201:
             raise Exception('Unable to create the photo object')

test/test-portrait-1.JPG

@@ -121,6 +121,16 @@ def test_create_profile(api):
     assert profile_id is not None
     assert result.status_code == 201
 
+def test_upload_photo(api, pytestconfig):
+    global job_id
+    global photo_id
+
+    result = api.upload_photo(f"{pytestconfig.rootdir}/test/test-portrait-1.JPG", 'job', job_id)
+
+    assert result['photo']['id'] is not None
+    photo_id = result['photo']['id']
+    assert result['upload_response'] == 200
+
 def test_get_profile(api):
     global profile_id
     result = api.get_profile(profile_id)
@@ -138,32 +148,6 @@ def test_list_photos(api):
     result = api.list_photos()
     assert result.status_code == 200
 
-def test_create_photo(api):
-    global photo_id
-    global profile_id
-
-    job_name = str(uuid.uuid4())
-    job_payload = {
-      'name': job_name,
-      'profile_id': 24
-    }
-
-    result = api.create_job(payload=job_payload)
-    job_id = result.json()['id']
-
-    photo_name = str(uuid.uuid4())
-    payload = {
-        "job_id": job_id,
-        "name": photo_name,
-        "use_cache_upload": False
-    }
-
-    photo_result = api.create_photo(payload=payload)
-    photo_id = photo_result.json()['id']
-
-    assert photo_id is not 0
-    assert result.status_code == 201
-
 def test_get_photo(api):
     global photo_id
     result = api.get_photo(photo_id)