feat: add support for calling start() again if state is only have-local-offer

Author: skyllo

src/peer.ts

@@ -10,6 +10,8 @@ import {
   setTracksEnabled,
 } from './utils';
 
+const POLITE_DEFAULT_VALUE = true;
+
 export default class Peer {
   private peerConn: RTCPeerConnection;
 
@@ -19,7 +21,7 @@ export default class Peer {
 
   private readonly emitter = new EventEmitter() as TypedEmitter<PeerEvents>;
 
-  private polite = true;
+  private polite = POLITE_DEFAULT_VALUE;
 
   private makingOffer = false;
 
@@ -165,8 +167,12 @@ export default class Peer {
     return this.peerConn;
   }
 
-  public start({ polite = false }: { polite?: boolean } = {}) {
+  public start({ polite = POLITE_DEFAULT_VALUE }: { polite?: boolean } = {}) {
     try {
+      // reset peer if only local offer is set
+      if (this.peerConn?.signalingState === 'have-local-offer') {
+        this.destroy();
+      }
       if (this.isClosed()) {
         this.init();
       }
@@ -209,7 +215,7 @@ export default class Peer {
           this.emit('signal', this.peerConn.localDescription);
         }
       }
-      this.polite = true;
+      this.polite = POLITE_DEFAULT_VALUE;
     } catch (err) {
       this.error('Failed to set local/remote descriptions', err);
     }
@@ -282,7 +288,7 @@ export default class Peer {
   /** Closes any active peer connection */
   public destroy() {
     if (!this.isClosed()) {
-      this.polite = true;
+      this.polite = POLITE_DEFAULT_VALUE;
       this.makingOffer = false;
       this.ignoreOffer = false;
       this.peerConn.close();

test/peer.spec.ts

@@ -70,6 +70,29 @@ test('should set the local stream and be active', async ({ page }) => {
   expect(isStreamLocalActive).toEqual(true);
 });
 
+test('should start peer if called twice afters listeners added', async ({ page }) => {
+  await page.evaluate(
+    () =>
+      new Promise<void>(async (resolve) => {
+        const peer1 = getPeer({ name: 'peer1' });
+        const peer2 = getPeer({ name: 'peer2' });
+
+        peer1.start();
+        peer2.start({ polite: false });
+
+        const stream = await window.Peer.getUserMedia();
+
+        peer1.on('connected', () => {
+          resolve();
+        });
+
+        setupPeers(peer1, peer2, stream);
+        peer1.start();
+        peer2.start({ polite: false });
+      })
+  );
+});
+
 test('should remove tracks from local stream peer', async ({ page }) => {
   const isNoTracks = await page.evaluate(async () => {
     const stream = await window.Peer.getUserMedia();
@@ -274,7 +297,7 @@ test('should connect two peers that make an offer simultaneously when one is pol
         });
 
         setupPeers(peer1, peer2, stream);
-        peer1.start({ polite: true });
+        peer1.start({ polite: false });
         peer2.start();
       })
   );