Skip to content

Commit 31f8c50

Browse files
committed
Fixed bug in Ddl::create_table
1 parent 06de6c8 commit 31f8c50

File tree

3 files changed

+19
-7
lines changed

3 files changed

+19
-7
lines changed

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,20 @@
22

33
All changes in this project will be noted in this file.
44

5+
## Version 0.6.1
6+
7+
> Breaking changes!
8+
9+
### Fixes
10+
11+
- Fixed missing entity name in query generation for DDL's `create_table` function
12+
13+
### Breaking
14+
15+
- The inner type of the `entity` field in `ddl::Keymap` was changed to `String` instead of `Option<String>`. Since this
16+
was never a public field, it should not affect you. However, if you depend on `Debug` fmt implementations then you should
17+
keep this in mind
18+
519
## Version 0.6.0
620

721
> Breaking changes

src/ddl.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ impl KeymapType {
7676
/// A Keymap Model Table
7777
///
7878
pub struct Keymap {
79-
entity: Option<String>,
79+
entity: String,
8080
ktype: Option<KeymapType>,
8181
vtype: Option<KeymapType>,
8282
volatile: bool,
@@ -87,7 +87,7 @@ impl Keymap {
8787
/// and the default volatility (by default a table is **not** volatile)
8888
pub fn new(entity: impl AsRef<str>) -> Self {
8989
Self {
90-
entity: Some(entity.as_ref().to_owned()),
90+
entity: entity.as_ref().to_owned(),
9191
ktype: None,
9292
vtype: None,
9393
volatile: false,
@@ -131,7 +131,7 @@ impl CreateTableIntoQuery for Keymap {
131131
.unwrap_or(&KeymapType::Binstr)
132132
.priv_to_string(),
133133
);
134-
let q = Query::from("CREATE").arg("TABLE").arg(arg);
134+
let q = Query::from("CREATE").arg("TABLE").arg(self.entity).arg(arg);
135135
if self.volatile {
136136
q.arg("volatile")
137137
} else {

src/types.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -436,10 +436,8 @@ impl<'a> IntoSkyhashBytes for &'a RawString {
436436
/// use skytable::sync::Connection;
437437
/// use skytable::actions::Actions;
438438
///
439-
/// fn main() {
440-
/// let mut con = Connection::new("127.0.0.1", 2003).unwrap();
441-
/// let mycsv: MyCSV = con.get("mycsv").unwrap();
442-
/// }
439+
/// let mut con = Connection::new("127.0.0.1", 2003).unwrap();
440+
/// let mycsv: MyCSV = con.get("mycsv").unwrap();
443441
/// ```
444442
///
445443
/// Now, you can use this as you like to turn [`Element`]s into your own (or primitive) types or

0 commit comments

Comments
 (0)