Use Open3.capture3.

Author: dblock

slack-api-explorer/commands/slack.rb

@@ -11,29 +11,19 @@ def self.call(client, data, match)
         expression.gsub! '—', '--'
         logger.info "SLACK: #{client.owner} - #{expression}"
         args, pipe = Shellwords.parse(expression)
-        execute(client, args) do |output, error|
-          if error && !error.blank?
-            client.say(channel: data.channel, text: "```\n#{error}```")
-          else
-            output = pipe ? JsonPath.on(output, pipe) : JSON.parse(output)
-            output = JSON.pretty_generate(output)
-            client.say(channel: data.channel, text: "```\n#{output}```")
-          end
+        output, error, _ = Open3.capture3(* ['slack', '--slack-api-token', client.owner.token, args].flatten)
+        error&.strip!
+        output&.strip!
+        if error && !error.blank?
+          client.say(channel: data.channel, text: "```\n#{error}```")
+        else
+          output = pipe ? JsonPath.on(output, pipe) : JSON.parse(output)
+          output = JSON.pretty_generate(output)
+          client.say(channel: data.channel, text: "```\n#{output}```")
         end
       rescue SyntaxError => e
         client.say(channel: data.channel, text: e.message)
       end
-
-      def self.execute(client, args)
-        Open3.popen3(* [
-          'slack',
-          '--slack-api-token',
-          client.owner.token,
-          args
-        ].flatten) do |_, stdout, stderr, _|
-          yield stdout.read&.strip, stderr.read&.strip
-        end
-      end
     end
   end
 end

spec/slack-api-explorer/commands/slack_spec.rb

@@ -23,7 +23,7 @@
     end
 
     before do
-      allow(described_class).to receive(:execute).and_yield(JSON.dump(json), nil)
+      allow(Open3).to receive(:capture3).and_return(JSON.dump(json), nil)
     end
 
     it 'returns raw json' do
@@ -73,7 +73,7 @@
     end
 
     before do
-      allow(described_class).to receive(:execute).and_yield(JSON.dump(json), nil)
+      allow(Open3).to receive(:capture3).and_return(JSON.dump(json), nil)
     end
 
     it 'returns multiple json values' do
@@ -92,9 +92,8 @@
 
   context 'chat postMessage' do
     it 'unescapes channel' do
-      expect(described_class).to receive(:execute).with(client,
-                                                        ['chat', 'postMessage', '--text',
-                                                         'Hello World', '--channel', '#C04KB5X4D']).and_yield(JSON.dump(ok: true), nil)
+      allow(Open3).to receive(:capture3).and_return(JSON.dump(ok: true), nil)
+      expect(Open3).to receive(:capture3).with('slack', '--slack-api-token', client.token, 'chat', 'postMessage', '--text', 'Hello World', '--channel', '#C04KB5X4D')
       expect(message: "#{SlackRubyBot.config.user} chat postMessage --text 'Hello World' --channel <#C04KB5X4D>").to respond_with_slack_message("```\n{\n  \"ok\": true\n}```")
     end
   end