Skip to content

Commit 87914da

Browse files
dblockdblock
committed
Upgraded to Ruby 3.3.5.
1 parent 0ec6e8b commit 87914da

24 files changed

+450
-252
lines changed

‎.github/workflows/rubocop.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- name: Set up Ruby
1212
uses: ruby/setup-ruby@v1
1313
with:
14-
ruby-version: "2.7.7"
14+
ruby-version: "3.3.5"
1515
bundler-cache: true
1616
- name: Run RuboCop
1717
run: bundle exec rubocop

‎.github/workflows/test.yml‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,22 @@ jobs:
66
test:
77
runs-on: ubuntu-latest
88
steps:
9-
- uses: actions/checkout@v3
10-
- uses: browser-actions/setup-firefox@latest
11-
with:
12-
firefox-version: "108.0"
13-
- uses: browser-actions/setup-geckodriver@latest
14-
with:
15-
geckodriver-version: "0.32.0"
9+
- uses: actions/checkout@v2
1610
- uses: ruby/setup-ruby@v1
1711
with:
18-
ruby-version: "2.7.7"
19-
bundler-cache: true
12+
ruby-version: "3.3.5"
2013
- uses: supercharge/[email protected]
2114
with:
22-
mongodb-version: "5"
23-
mongodb-db: slack_api_explorer_test
24-
- name: Run tests
25-
uses: GabrielBB/xvfb-action@v1
15+
mongodb-version: "7.0"
16+
- uses: browser-actions/setup-geckodriver@latest
17+
with:
18+
geckodriver-version: "0.34.0"
19+
- uses: browser-actions/setup-firefox@v1
20+
with:
21+
firefox-version: "129.0.2"
22+
- run: |
23+
bundle install
24+
- uses: GabrielBB/xvfb-action@v1
2625
with:
27-
run: bundle exec rake
26+
run: |
27+
bundle exec rake spec

‎.rubocop.yml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
AllCops:
2+
NewCops: enable
3+
TargetRubyVersion: 3.3
24
Exclude:
35
- vendor/**/*
46
- bin/**/*
@@ -10,3 +12,8 @@ Metrics:
1012
Enabled: false
1113

1214
inherit_from: .rubocop_todo.yml
15+
16+
require:
17+
- rubocop-capybara
18+
- rubocop-rake
19+
- rubocop-rspec

‎.rubocop_todo.yml‎

Lines changed: 109 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,127 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2019-04-16 08:56:55 -0400 using RuboCop version 0.67.2.
3+
# on 2024-10-20 13:24:03 UTC using RuboCop version 1.67.0.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
77
# versions of RuboCop, may require this file to be generated again.
88

99
# Offense count: 1
10-
# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
10+
# Configuration parameters: ExpectMatchingDefinition, CheckDefinitionPathHierarchy, CheckDefinitionPathHierarchyRoots, Regex, IgnoreExecutableScripts, AllowedAcronyms.
11+
# CheckDefinitionPathHierarchyRoots: lib, spec, test, src
1112
# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
1213
Naming/FileName:
1314
Exclude:
15+
- 'Rakefile.rb'
1416
- 'slack-api-explorer.rb'
1517

1618
# Offense count: 2
17-
# Configuration parameters: Blacklist.
18-
# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
19+
# Configuration parameters: ForbiddenDelimiters.
20+
# ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
1921
Naming/HeredocDelimiterNaming:
2022
Exclude:
2123
- 'slack-api-explorer/commands/help.rb'
2224
- 'slack-api-explorer/info.rb'
25+
26+
# Offense count: 6
27+
RSpec/AnyInstance:
28+
Exclude:
29+
- 'spec/api/endpoints/status_endpoint_spec.rb'
30+
- 'spec/api/endpoints/teams_endpoint_spec.rb'
31+
- 'spec/integration/teams_spec.rb'
32+
33+
# Offense count: 17
34+
# Configuration parameters: Prefixes, AllowedPatterns.
35+
# Prefixes: when, with, without
36+
RSpec/ContextWording:
37+
Exclude:
38+
- 'spec/api/404_spec.rb'
39+
- 'spec/api/cors_spec.rb'
40+
- 'spec/api/endpoints/status_endpoint_spec.rb'
41+
- 'spec/api/endpoints/teams_endpoint_spec.rb'
42+
- 'spec/api/swagger_documentation_spec.rb'
43+
- 'spec/integration/teams_spec.rb'
44+
- 'spec/slack-api-explorer/commands/slack_spec.rb'
45+
- 'spec/support/api/endpoints/it_behaves_like_a_cursor_api.rb'
46+
47+
# Offense count: 10
48+
# Configuration parameters: CountAsOne.
49+
RSpec/ExampleLength:
50+
Max: 27
51+
52+
# Offense count: 1
53+
# Configuration parameters: AssignmentOnly.
54+
RSpec/InstanceVariable:
55+
Exclude:
56+
- 'spec/support/api/endpoints/it_behaves_like_a_cursor_api.rb'
57+
58+
# Offense count: 5
59+
RSpec/LetSetup:
60+
Exclude:
61+
- 'spec/api/endpoints/status_endpoint_spec.rb'
62+
- 'spec/api/endpoints/teams_endpoint_spec.rb'
63+
64+
# Offense count: 13
65+
# Configuration parameters: .
66+
# SupportedStyles: have_received, receive
67+
RSpec/MessageSpies:
68+
EnforcedStyle: receive
69+
70+
# Offense count: 28
71+
RSpec/MultipleExpectations:
72+
Max: 7
73+
74+
# Offense count: 2
75+
# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
76+
# SupportedStyles: always, named_only
77+
RSpec/NamedSubject:
78+
Exclude:
79+
- 'spec/api/swagger_documentation_spec.rb'
80+
81+
# Offense count: 1
82+
# Configuration parameters: AllowedGroups.
83+
RSpec/NestedGroups:
84+
Max: 4
85+
86+
# Offense count: 2
87+
RSpec/RepeatedExampleGroupDescription:
88+
Exclude:
89+
- 'spec/api/endpoints/teams_endpoint_spec.rb'
90+
91+
# Offense count: 8
92+
# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
93+
# Include: **/*_spec.rb
94+
RSpec/SpecFilePathFormat:
95+
Exclude:
96+
- '**/spec/routing/**/*'
97+
- 'spec/api/404_spec.rb'
98+
- 'spec/api/cors_spec.rb'
99+
- 'spec/api/robots_spec.rb'
100+
- 'spec/api/swagger_documentation_spec.rb'
101+
- 'spec/slack-api-explorer/commands/default_spec.rb'
102+
- 'spec/slack-api-explorer/commands/slack_spec.rb'
103+
- 'spec/slack-api-explorer/commands/unknown_spec.rb'
104+
- 'spec/slack-api-explorer/version_spec.rb'
105+
106+
# Offense count: 1
107+
RSpec/StubbedMock:
108+
Exclude:
109+
- 'spec/api/endpoints/teams_endpoint_spec.rb'
110+
111+
# Offense count: 2
112+
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
113+
RSpec/VerifiedDoubles:
114+
Exclude:
115+
- 'spec/api/endpoints/teams_endpoint_spec.rb'
116+
117+
# Offense count: 1
118+
RSpec/VoidExpect:
119+
Exclude:
120+
- 'spec/integration/teams_spec.rb'
121+
122+
# Offense count: 15
123+
# This cop supports safe autocorrection (--autocorrect).
124+
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
125+
# URISchemes: http, https
126+
Layout/LineLength:
127+
Max: 175

‎Gemfile‎

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,28 @@
11
source 'http://rubygems.org'
22

3-
ruby '2.7.7'
3+
ruby '3.3.5'
44

5-
gem 'giphy'
65
gem 'irb'
76
gem 'jsonpath', '0.9.0'
87
gem 'kaminari-grape'
98
gem 'mongoid'
109
gem 'mongoid-scroll'
11-
gem 'newrelic-slack-ruby-bot'
1210
gem 'newrelic_rpm'
13-
gem 'rack', '~> 2.2'
11+
gem 'newrelic-slack-ruby-bot'
12+
gem 'rack'
1413
gem 'rack-robotz'
1514
gem 'rack-server-pages'
16-
gem 'slack-ruby-bot-server'
1715
gem 'slack-ruby-bot-server-mailchimp'
1816
gem 'slack-ruby-bot-server-rtm'
1917
gem 'unicorn'
2018

2119
group :development, :test do
2220
gem 'foreman'
2321
gem 'rake'
24-
gem 'rubocop', '0.76.0'
22+
gem 'rubocop'
23+
gem 'rubocop-capybara'
24+
gem 'rubocop-rake'
25+
gem 'rubocop-rspec'
2526
end
2627

2728
group :development do
@@ -30,11 +31,13 @@ end
3031

3132
group :test do
3233
gem 'capybara'
33-
gem 'database_cleaner', '~> 1.8.4'
34+
gem 'database_cleaner-mongoid'
3435
gem 'fabrication'
3536
gem 'faker'
36-
gem 'hyperclient', '~> 0.9'
37+
gem 'faraday-rack'
38+
gem 'hyperclient'
3739
gem 'rack-test'
40+
gem 'rackup'
3841
gem 'rspec'
3942
gem 'selenium-webdriver'
4043
gem 'vcr'

0 commit comments

Comments
 (0)