Skip to content

Commit 304cec3

Browse files
committed
Address PR comments
1 parent 651e556 commit 304cec3

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

CHANGELOG.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
#### 0.11.2 (Next)
44

5-
* [#105](https://github.com/slack-ruby/slack-ruby-bot-server/pull/105): Update README with OAuth code grant detail - [@jcraigk](https://github.com/jcraigk).
65
* Your contribution here.
76

87
#### 0.11.1 (2019/5/17)

README.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ Start with one of the samples above, which contain a couple of custom commands,
6666

6767
![](images/create-app.png)
6868

69-
Follow Slack's instructions, note the app client ID and secret, give the bot a default name, etc. The redirect URL should be the location of your app; for local testing purposes use a public tunneling service such as [ngrok](https://ngrok.com/) to expose local port 9292.
69+
Follow Slack's instructions, note the app client ID and secret, give the bot a default name, etc. The redirect URL should be the location of your app. For local testing purposes use a public tunneling service such as [ngrok](https://ngrok.com/) to expose local port 9292.
7070

7171
Within your application, edit your `.env` file and add `SLACK_CLIENT_ID=...` and `SLACK_CLIENT_SECRET=...` in it.
7272

@@ -82,7 +82,7 @@ The button itself contains a link that looks like this:
8282
https://slack.com/oauth/authorize?scope=bot&client_id=<%= ENV['SLACK_CLIENT_ID'] %>
8383
```
8484

85-
Once clicked, the user is taken through the authorization process at Slack's site. Upon successful completion, a callback containing a temporary code is sent to the redirect URL you specified. The endpoint at that URL should contain code that looks like this:
85+
Once clicked, the user is taken through the authorization process at Slack's site. Upon successful completion, a callback containing a temporary code is sent to the redirect URL you specified. The endpoint at that URL contains code that looks like this:
8686

8787
```ruby
8888
# Instantiate a web client
@@ -99,9 +99,7 @@ rc = client.oauth_access(
9999
token = rc['bot']['bot_access_token']
100100
```
101101

102-
The token should be stored in persistent storage and used each time a Slack client is instantiated for the specific team.
103-
104-
Note that other libraries may be used to assist with OAuth interactions, such as [OAuth2](https://github.com/oauth-xx/oauth2).
102+
The token is stored in persistent storage and used each time a Slack client is instantiated for the specific team.
105103

106104
### API
107105

0 commit comments

Comments
 (0)