Remove configure_global_aliases.

Author: dblock

lib/slack-ruby-bot-server/app.rb

@@ -1,10 +1,11 @@
 module SlackRubyBotServer
   class App
+    include SlackRubyBotServer::Loggable
+
     def prepare!
       check_database!
       init_database!
       purge_inactive_teams!
-      configure_global_aliases!
     end
 
     def self.instance
@@ -13,13 +14,6 @@ def self.instance
 
     private
 
-    def logger
-      @logger ||= begin
-        STDOUT.sync = true
-        Logger.new(STDOUT)
-      end
-    end
-
     def check_database!
       SlackRubyBotServer::DatabaseAdapter.check!
     end
@@ -31,11 +25,5 @@ def init_database!
     def purge_inactive_teams!
       Team.purge!
     end
-
-    def configure_global_aliases!
-      SlackRubyBot.configure do |config|
-        config.aliases = ENV['SLACK_RUBY_BOT_ALIASES'].split(' ') if ENV['SLACK_RUBY_BOT_ALIASES']
-      end
-    end
   end
 end

spec/integration/teams_spec.rb

@@ -23,23 +23,21 @@
       end
       it 'registers a team' do
         expect do
-          visit '/?code=code'
+          visit '/?v1&code=code'
           expect(page.find('#messages')).to have_content 'Team successfully registered!'
         end.to change(Team, :count).by(1)
       end
       it 'includes optional parameter' do
         expect(SlackRubyBotServer::Service.instance).to receive(:create!).with(instance_of(Team), state: 'property')
-        visit '/?code=code&state=property'
+        visit '/?v1&code=code&state=property'
       end
     end
     context 'homepage' do
       before do
         visit '/?v1'
       end
-      it 'displays index.html page' do
-        expect(title).to eq('Slack Ruby Bot Server')
-      end
       it 'includes a link to add to slack with the client id' do
+        expect(title).to eq('Slack Ruby Bot Server')
         expect(find("a[href='https://slack.com/oauth/authorize?scope=channels:read+channels:write&client_id=client_id"))
       end
     end
@@ -55,26 +53,22 @@
       end
       it 'registers a team' do
         expect do
-          visit '/?code=code'
+          visit '/?v2&code=code'
           expect(page.find('#messages')).to have_content 'Team successfully registered!'
         end.to change(Team, :count).by(1)
       end
       it 'includes optional parameter' do
         expect(SlackRubyBotServer::Service.instance).to receive(:create!).with(instance_of(Team), state: 'property')
-        visit '/?code=code&state=property'
+        visit '/?v2&code=code&state=property'
       end
     end
     context 'homepage' do
       before do
         visit '/?v2'
       end
-      it 'displays index.html page' do
+      it 'includes a link to add to slack with the client id' do
         expect(title).to eq('Slack Ruby Bot Server')
-      end
-      context 'oauth' do
-        it 'includes a link to add to slack with the client id' do
-          expect(find("a[href='https://slack.com/oauth/v2/authorize?scope=channels:read+channels:write&client_id=client_id"))
-        end
+        expect(find("a[href='https://slack.com/oauth/v2/authorize?scope=channels:read+channels:write&client_id=client_id"))
       end
     end
   end