Do not raise errors on purge.

Author: dblock

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-04-26 17:46:16 -0400 using RuboCop version 0.81.0.
+# on 2020-06-16 16:54:39 -0400 using RuboCop version 0.81.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -44,11 +44,13 @@ Naming/HeredocDelimiterNaming:
     - 'sample_apps/sample_app_activerecord/commands/help.rb'
     - 'sample_apps/sample_app_mongoid/commands/help.rb'
 
-# Offense count: 1
+# Offense count: 3
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
 Naming/MethodParameterName:
   Exclude:
+    - 'lib/slack-ruby-bot-server/models/team/activerecord.rb'
+    - 'lib/slack-ruby-bot-server/models/team/mongoid.rb'
     - 'lib/slack-ruby-bot-server/service.rb'
 
 # Offense count: 1

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 #### 0.12.1 (Next)
 
+* [#118](https://github.com/slack-ruby/slack-ruby-bot-server/pull/118): Do not fail to start on errors in `Team#purge!` - [@dblock](https://github.com/dblock).
 * Your contribution here.
 
 #### 0.12.0 (2020/4/26)

lib/slack-ruby-bot-server/models/team/activerecord.rb

@@ -3,11 +3,14 @@
 class Team < ActiveRecord::Base
   include Methods
 
-  def self.purge!
-    # destroy teams inactive for two weeks
-    Team.where(active: false).where('updated_at <= ?', 2.weeks.ago).each do |team|
-      puts "Destroying #{team}, inactive since #{team.updated_at}, over two weeks ago."
-      team.destroy
+  def self.purge!(dt = 2.weeks.ago)
+    Team.where(active: false).where('updated_at <= ?', dt).each do |team|
+      begin
+        logger.info "Destroying #{team}, inactive since #{team.updated_at}."
+        team.destroy
+      rescue StandardError => e
+        logger.warn "Error destroying #{team}, #{e.message}."
+      end
     end
   end
 end

lib/slack-ruby-bot-server/models/team/mongoid.rb

@@ -15,11 +15,15 @@ class Team
 
   include Methods
 
-  def self.purge!
+  def self.purge!(dt = 2.weeks.ago)
     # destroy teams inactive for two weeks
-    Team.where(active: false, :updated_at.lte => 2.weeks.ago).each do |team|
-      Mongoid.logger.info "Destroying #{team}, inactive since #{team.updated_at}, over two weeks ago."
-      team.destroy
+    Team.where(active: false, :updated_at.lte => dt).each do |team|
+      begin
+        logger.info "Destroying #{team}, inactive since #{team.updated_at}."
+        team.destroy
+      rescue StandardError => e
+        logger.warn "Error destroying #{team}, #{e.message}."
+      end
     end
   end
 end

spec/models/team_spec.rb

@@ -17,5 +17,13 @@
       expect(Team.where(id: inactive_team_two_weeks_ago.id).first).to be nil
       expect(Team.where(id: inactive_team_a_month_ago.id).first).to be nil
     end
+    it 'does not raise errors when a team cannot be destroyed' do
+      allow_any_instance_of(Team).to receive(:destroy).and_raise(StandardError, 'cannot be destroyed')
+      expect do
+        expect do
+          Team.purge!
+        end.to_not change(Team, :count)
+      end.to_not raise_error
+    end
   end
 end