Split register into register and messages.js.

Author: dblock

public/index.html.erb

@@ -3,6 +3,7 @@
   <title>Slack Ruby Bot Server</title>
   <script src="/scripts/jquery-1.7.1.min.js"></script>
   <script src="/scripts/url.min.js"></script>
+  <script src="/scripts/messages.js"></script>
   <script src="/scripts/register.js"></script>
   <script src="/scripts/stats.js"></script>
 </head>

public/scripts/messages.js

@@ -0,0 +1,33 @@
+var SlackRubyBotServer = {};
+
+$(document).ready(function() {
+
+  SlackRubyBotServer.message = function(text) {
+    $('#messages').fadeOut('slow', function() {
+      $('#messages').fadeIn('slow').html(text)
+    });
+  };
+
+  SlackRubyBotServer.error = function(xhr) {
+    try {
+      var message;
+      if (xhr.responseText) {
+        var rc = JSON.parse(xhr.responseText);
+        if (rc && rc.message) {
+          message = rc.message;
+          if (message == 'invalid_code') {
+            message = 'The code returned from the OAuth workflow was invalid.'
+          } else if (message == 'code_already_used') {
+            message = 'The code returned from the OAuth workflow has already been used.'
+          }
+        }
+      }
+
+      SlackRubyBotServer.message(message || xhr.statusText || xhr.responseText || 'Unexpected Error');
+
+    } catch(err) {
+      SlackRubyBotServer.message(err.message);
+    }
+  };
+
+});

public/scripts/register.js

@@ -1,35 +1,4 @@
-var SlackRubyBotServer = {};
-
 $(document).ready(function() {
-
-  SlackRubyBotServer.message = function(text) {
-    $('#messages').fadeOut('slow', function() {
-      $('#messages').fadeIn('slow').html(text)
-    });
-  };
-
-  SlackRubyBotServer.error = function(xhr) {
-    try {
-      var message;
-      if (xhr.responseText) {
-        var rc = JSON.parse(xhr.responseText);
-        if (rc && rc.message) {
-          message = rc.message;
-          if (message == 'invalid_code') {
-            message = 'The code returned from the OAuth workflow was invalid.'
-          } else if (message == 'code_already_used') {
-            message = 'The code returned from the OAuth workflow has already been used.'
-          }
-        }
-      }
-
-      SlackRubyBotServer.message(message || xhr.statusText || xhr.responseText || 'Unexpected Error');
-
-    } catch(err) {
-      SlackRubyBotServer.message(err.message);
-    }
-  };
-
   // Slack OAuth
   var code = $.url('?code')
   var state = $.url('?state')

spec/api/middleware_spec.rb

@@ -19,7 +19,7 @@ def middleware_classes(app)
       SlackRubyBotServer.configure do |config|
         config.view_paths << 'custom'
       end
-      server_pages = middleware_classes(SlackRubyBotServer::Api::Middleware.instance)[2]
+      server_pages = middleware_classes(SlackRubyBotServer::Api::Middleware.instance)[-2]
       expect(server_pages).to be_a Rack::ServerPages
       config = server_pages.instance_variable_get(:@config)
       expect(config[:view_path].count).to eq 4