Skip to content

Commit b50f870

Browse files
committed
Removed GIFs.
1 parent dffcf86 commit b50f870

File tree

11 files changed

+13
-14
lines changed

11 files changed

+13
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
#### 0.12.2 (Next)
44

5+
* [#120](https://github.com/slack-ruby/slack-ruby-bot-server/pull/120): Removed GIFs - [@dblock](https://github.com/dblock).
56
* Your contribution here.
67

78
#### 0.12.1 (2020/5/16)

Gemfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,3 +40,5 @@ end
4040
group :test do
4141
gem 'slack-ruby-danger', '~> 0.1.0', require: false
4242
end
43+
44+
gem 'slack-ruby-bot', github: 'slack-ruby/slack-ruby-bot'

lib/slack-ruby-bot-server/ext/activerecord/slack-ruby-bot/commands/base.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ def invoke(client, data)
99
rescue StandardError => e
1010
logger.info "#{name.demodulize.upcase}: #{client.owner}, #{e.class}: #{e}"
1111
logger.debug e.backtrace.join("\n")
12-
client.say(channel: data.channel, text: e.message, gif: 'error')
12+
client.say(channel: data.channel, text: e.message)
1313
true
1414
end
1515
end

lib/slack-ruby-bot-server/ext/mongoid/slack-ruby-bot/commands/base.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,12 @@ def invoke(client, data)
88
_invoke client, data
99
rescue Mongoid::Errors::Validations => e
1010
logger.info "#{name.demodulize.upcase}: #{client.owner}, error - #{e.document.class}, #{e.document.errors.to_hash}"
11-
client.say(channel: data.channel, text: e.document.errors.first[1], gif: 'error')
11+
client.say(channel: data.channel, text: e.document.errors.first[1])
1212
true
1313
rescue StandardError => e
1414
logger.info "#{name.demodulize.upcase}: #{client.owner}, #{e.class}: #{e}"
1515
logger.debug e.backtrace.join("\n")
16-
client.say(channel: data.channel, text: e.message, gif: 'error')
16+
client.say(channel: data.channel, text: e.message)
1717
true
1818
end
1919
end

sample_apps/sample_app_activerecord/commands/help.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class Help < SlackRubyBot::Commands::Base
1313
EOS
1414
def self.call(client, data, _match)
1515
client.say(channel: data.channel, text: [HELP, SlackRubyBotServer::INFO].join("\n"))
16-
client.say(channel: data.channel, gif: 'help')
16+
client.say(channel: data.channel)
1717
logger.info "HELP: #{client.owner}, user=#{data.user}"
1818
end
1919
end

sample_apps/sample_app_activerecord/spec/commands/help_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
let(:message_hook) { SlackRubyBot::Hooks::Message.new }
99
it 'default' do
1010
expect(client).to receive(:say).with(channel: 'channel', text: [Help::HELP, SlackRubyBotServer::INFO].join("\n"))
11-
expect(client).to receive(:say).with(channel: 'channel', gif: 'help')
11+
expect(client).to receive(:say).with(channel: 'channel')
1212
message_hook.call(client, Hashie::Mash.new(channel: 'channel', text: "#{SlackRubyBot.config.user} help"))
1313
end
1414
end

sample_apps/sample_app_mongoid/commands/help.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ class Help < SlackRubyBot::Commands::Base
1313
EOS
1414
def self.call(client, data, _match)
1515
client.say(channel: data.channel, text: [HELP, SlackRubyBotServer::INFO].join("\n"))
16-
client.say(channel: data.channel, gif: 'help')
16+
client.say(channel: data.channel)
1717
logger.info "HELP: #{client.owner}, user=#{data.user}"
1818
end
1919
end

sample_apps/sample_app_mongoid/spec/commands/help_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
let(:message_hook) { SlackRubyBot::Hooks::Message.new }
99
it 'default' do
1010
expect(client).to receive(:say).with(channel: 'channel', text: [Help::HELP, SlackRubyBotServer::INFO].join("\n"))
11-
expect(client).to receive(:say).with(channel: 'channel', gif: 'help')
11+
expect(client).to receive(:say).with(channel: 'channel')
1212
message_hook.call(client, Hashie::Mash.new(channel: 'channel', text: "#{SlackRubyBot.config.user} help"))
1313
end
1414
end

spec/ext/activerecord/commands_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
end
1212

1313
it 'responds to channel with exception message' do
14-
expect(client).to receive(:say).with(channel: 'channel', text: 'mock error', gif: 'error')
14+
expect(client).to receive(:say).with(channel: 'channel', text: 'mock error')
1515
message_hook.call(client, Hashie::Mash.new(text: 'raising exception', channel: 'channel', user: 'user'))
1616
end
1717
end

spec/ext/mongoid/commands_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
end
1212

1313
it 'responds to channel with exception message' do
14-
expect(client).to receive(:say).with(channel: 'channel', text: 'mock error', gif: 'error')
14+
expect(client).to receive(:say).with(channel: 'channel', text: 'mock error')
1515
message_hook.call(client, Hashie::Mash.new(text: 'raising exception', channel: 'channel', user: 'user'))
1616
end
1717
end
@@ -28,7 +28,7 @@ class MockDocument
2828
end
2929

3030
it 'responds to channel with exception message' do
31-
expect(client).to receive(:say).with(channel: 'channel', text: "undefined method `mock_id' for #{mock_document.inspect}", gif: 'error')
31+
expect(client).to receive(:say).with(channel: 'channel', text: "undefined method `mock_id' for #{mock_document.inspect}")
3232
message_hook.call(client, Hashie::Mash.new(text: 'raising exception', channel: 'channel', user: 'user'))
3333
end
3434
end

0 commit comments

Comments
 (0)