Replace celluloid-io with async-websocket.

Author: dblock

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-08-22 08:29:35 -0400 using RuboCop version 0.58.2.
+# on 2018-08-27 14:23:13 +0200 using RuboCop version 0.58.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

CHANGELOG.md

@@ -1,7 +1,8 @@
 ### Changelog
 
-#### 0.7.1 (Next)
+#### 0.8.0 (Next)
 
+* [#75](https://github.com/slack-ruby/slack-ruby-bot-server/pull/75): Default to `async-websocket` instead of `celluloid-io` - [@dblock](https://github.com/dblock).
 * Your contribution here.
 
 #### 0.7.0 (8/22/2018)

Gemfile

@@ -16,6 +16,9 @@ else
   warn "Invalid ENV['DATABASE_ADAPTER']: #{ENV['DATABASE_ADAPTER']}."
 end
 
+gem 'slack-ruby-bot', github: 'dblock/slack-ruby-bot', branch: 'async'
+gem 'slack-ruby-client', github: 'dblock/slack-ruby-client', branch: 'async'
+
 gemspec
 
 group :development, :test do

UPGRADING.md

@@ -1,6 +1,14 @@
 Upgrading Slack-Ruby-Bot-Server
 ===============================
 
+### Upgrading to >= 0.8.0
+
+### Different Asynchronous I/O Library
+
+The library now uses [async-websocket](https://github.com/socketry/async-websocket) instead of [celluloid-io](https://github.com/celluloid/celluloid-io). If your application is built on Celluloid you may need to make changes and use `Async::Reactor.run` and the likes.
+
+See [#75](https://github.com/slack-ruby/slack-ruby-bot-server/pull/75) for more information.
+
 ### Upgrading to >= 0.7.0
 
 #### New Ping Worker

lib/slack-ruby-bot-server.rb

@@ -1,4 +1,4 @@
-require 'celluloid/current'
+require 'async/websocket'
 
 require 'grape-swagger'
 require 'slack-ruby-bot'

lib/slack-ruby-bot-server/ping.rb

@@ -1,7 +1,5 @@
 module SlackRubyBotServer
   class Ping
-    include Celluloid
-
     attr_reader :client
     attr_reader :options
     attr_reader :error_count
@@ -13,8 +11,11 @@ def initialize(client, options = {})
     end
 
     def start!
-      every ping_interval do
-        check!
+      ::Async::Reactor.run do |task|
+        loop do
+          task.sleep ping_interval
+          break unless check!
+        end
       end
     end
 
@@ -23,16 +24,18 @@ def start!
     def check!
       if online?
         @error_count = 0
+        true
       else
         down!
       end
     rescue StandardError => e
       case e.message
       when 'account_inactive', 'invalid_auth' then
         logger.warn "Error pinging team #{owner.id}: #{e.message}, terminating."
-        terminate
+        false
       else
         logger.warn "Error pinging team #{owner.id}: #{e.message}."
+        true
       end
     end
 
@@ -51,14 +54,14 @@ def presence
     def down!
       logger.warn "DOWN: #{owner}, #{retries_left} #{retries_left == 1 ? 'retry' : 'retries'} left"
       @error_count += 1
-      return if retries_left?
+      return true if retries_left?
       restart!
+      false
     end
 
     def restart!
       logger.warn "RESTART: #{owner}"
-      driver.emit(:close, WebSocket::Driver::CloseEvent.new(1001, 'bot offline')) if driver
-      terminate
+      driver.close if driver
     end
 
     def ping_interval

lib/slack-ruby-bot-server/version.rb

@@ -1,3 +1,3 @@
 module SlackRubyBotServer
-  VERSION = '0.7.1'.freeze
+  VERSION = '0.8.0'.freeze
 end

sample_apps/sample_app_activerecord/Gemfile

@@ -7,6 +7,7 @@ gem 'pg'
 gem 'rack-server-pages'
 gem 'rack-test'
 gem 'slack-ruby-bot-server', path: '../../'
+gem 'slack-ruby-client', github: 'dblock/slack-ruby-client', branch: 'async'
 
 group :development, :test do
   gem 'standalone_migrations', '~> 5.2'

sample_apps/sample_app_activerecord/config.ru

@@ -7,12 +7,6 @@ require 'yaml'
 
 ActiveRecord::Base.establish_connection(YAML.load_file('config/postgresql.yml')[ENV['RACK_ENV']])
 
-if ENV['RACK_ENV'] == 'development'
-  puts 'Loading NewRelic in developer mode ...'
-  require 'new_relic/rack/developer_mode'
-  use NewRelic::Rack::DeveloperMode
-end
-
 NewRelic::Agent.manual_start
 
 SlackRubyBotServer::App.instance.prepare!

sample_apps/sample_app_mongoid/Gemfile

@@ -3,6 +3,7 @@ source 'https://rubygems.org'
 gem 'mongoid'
 gem 'newrelic-slack-ruby-bot'
 gem 'slack-ruby-bot-server', path: '../../'
+gem 'slack-ruby-client', github: 'dblock/slack-ruby-client', branch: 'async'
 
 gem 'kaminari-mongoid'
 gem 'mongoid-scroll'