Rename files_upload_external to files_upload_v2 (#536)

Author: gregsaab

CHANGELOG.md

@@ -5,6 +5,7 @@
 * [#528](https://github.com/slack-ruby/slack-ruby-client/pull/528): Don't treat asterisks in list items as italic in markdown - [@rspeicher](https://github.com/rspeicher).
 * [#530](https://github.com/slack-ruby/slack-ruby-client/pull/530): Specify dependency on logger - [@rwstauner](https://github.com/rwstauner).
 * [#533](https://github.com/slack-ruby/slack-ruby-client/pull/533): Added `files_upload_external` - [@gregsaab](https://github.com/gregsaab).
+* [#536](https://github.com/slack-ruby/slack-ruby-client/pull/536): Rename `files_upload_external` to `files_upload_v2` - [@gregsaab](https://github.com/gregsaab).
 * Your contribution here.
 
 ### 2.4.0 (2024/07/14)

README.md

@@ -173,10 +173,10 @@ general_channel = channels.detect { |c| c.name == 'general' }
 
 Upload files with [sequenced API calls](https://api.slack.com/messaging/files#uploading_files).
 
-This library provides a helper method `files_upload_external` that wraps the three separate API calls.
+This library provides a helper method `files_upload_v2` that wraps the three separate API calls.
 
 ```ruby
-client.files_upload_external(
+client.files_upload_v2(
   # required options
   channels: 'C000000,C000001', # comma delimited channel ids, only one channel is required
   filename: 'results.pdf', # this is used for the file title, unless a :title option is provided

lib/slack/web/api/helpers/files.rb

@@ -27,7 +27,7 @@ module Files
           #   Provide another message's ts value to upload this file as a reply.
           #   Never use a reply's ts value; use its parent instead.
           #   Also make sure to provide only one channel when using 'thread_ts'.
-          def files_upload_external(options = {})
+          def files_upload_v2(options = {})
             %i[filename content channels].each do |param|
               raise ArgumentError, "Required argument :#{param} missing" if options[param].nil?
             end

…ures/slack/web/files_upload_external.yml …c/fixtures/slack/web/files_upload_v2.ymlspec/fixtures/slack/web/files_upload_external.yml renamed to spec/fixtures/slack/web/files_upload_v2.yml spec/fixtures/slack/web/files_upload_external.yml renamed to spec/fixtures/slack/web/files_upload_v2.yml

@@ -20,35 +20,35 @@
 
       it 'raises an argument error' do
         expect do
-          client.files_upload_external(params)
+          client.files_upload_v2(params)
         end.to raise_error ArgumentError, /Required argument :#{arg} missing/
       end
     end
   end
 
-  context 'when all required options are sent', vcr: { cassette_name: 'web/files_upload_external' } do
+  context 'when all required options are sent', vcr: { cassette_name: 'web/files_upload_v2' } do
     it 'completes the upload' do
-      expect(client.files_upload_external(
+      expect(client.files_upload_v2(
         filename: 'test.txt',
         content: 'Test File Contents',
         channels: 'C08AZ76CA4V'
       ).files.size).to eq 1
     end
   end
 
-  context 'when using a list for channels', vcr: { cassette_name: 'web/files_upload_external_with_channels_list' } do
+  context 'when using a list for channels', vcr: { cassette_name: 'web/files_upload_v2_with_channels_list' } do
     it 'completes the upload' do
-      expect(client.files_upload_external(
+      expect(client.files_upload_v2(
         filename: 'test.txt',
         content: 'Test File Contents',
         channels: 'C08AZ76CA4V,C08BHPZBZ8A'
       ).files.size).to eq 1
     end
   end
 
-  context 'when all options specified', vcr: { cassette_name: 'web/files_upload_external_with_all_options' } do
+  context 'when all options specified', vcr: { cassette_name: 'web/files_upload_v2_with_all_options' } do
     it 'completes the upload' do
-      expect(client.files_upload_external(
+      expect(client.files_upload_v2(
         title: 'title',
         filename: 'test.txt',
         content: 'Test File Contents',