put option generation back in the create_connection method, update rubocop_todo

Author: gregsaab

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-11-06 16:01:45 UTC using RuboCop version 1.26.1.
+# on 2025-02-03 19:01:09 UTC using RuboCop version 1.26.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -44,17 +44,17 @@ Lint/RedundantCopDisableDirective:
   Exclude:
     - 'lib/slack-ruby-client.rb'
 
-# Offense count: 12
+# Offense count: 13
 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 36
 
-# Offense count: 4
+# Offense count: 5
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 10
+  Max: 11
 
-# Offense count: 13
+# Offense count: 14
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 26
@@ -64,10 +64,10 @@ Metrics/MethodLength:
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 10
+  Max: 11
 
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
@@ -94,12 +94,12 @@ RSpec/ContextMethod:
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 65
+# Offense count: 66
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 18
 
-# Offense count: 18
+# Offense count: 19
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:

lib/slack/web/faraday/connection.rb

@@ -3,7 +3,7 @@ module Slack
   module Web
     module Faraday
       module Connection
-        def default_options
+        def create_connection(expect_json_response: true)
           options = {
             headers: { 'Accept' => 'application/json; charset=utf-8' }
           }
@@ -15,11 +15,7 @@ def default_options
           request_options[:timeout] = timeout if timeout
           request_options[:open_timeout] = open_timeout if open_timeout
           options[:request] = request_options if request_options.any?
-          options
-        end
 
-        def create_connection(expect_json_response: true)
-          options = default_options
           ::Faraday::Connection.new(endpoint, options) do |connection|
             connection.request :multipart
             connection.request :url_encoded