Revise *_id_page_size handling

Author: eizengan

README.md

@@ -293,8 +293,8 @@ logger                       | Optional `Logger` instance that logs HTTP request
 timeout                      | Optional open/read timeout in seconds.
 open_timeout                 | Optional connection open timeout in seconds.
 default_page_size            | Optional page size for paginated requests, default is _100_.
-conversations_id_page_size   | Optional page size for conversations_list requests made when calculating conversation id from a conversation name, default is _equal to default_page_size_.
-users_id_page_size           | Optional page size for users_list requests made when calculating user id from a user name, default is _equal to default_page_size_.
+conversations_id_page_size   | Optional page size for conversations_list requests made when calculating conversation id from a conversation name, default is _nil_, which will use the default_page_size.
+users_id_page_size           | Optional page size for users_list requests made when calculating user id from a user name, default is _nil_, which will use the default_page_size.
 default_max_retries          | Optional number of retries for paginated requests, default is _100_.
 adapter                      | Optional HTTP adapter to use, defaults to `Faraday.default_adapter`.
 

lib/slack/web/api/mixins/conversations.id.rb

@@ -26,7 +26,7 @@ def conversations_id(options = {})
               prefix: '#',
               enum_method: :conversations_list,
               list_method: :channels,
-              options: { limit: limit }
+              options: { limit: limit }.compact
             )
           end
         end

lib/slack/web/api/mixins/users.id.rb

@@ -26,7 +26,7 @@ def users_id(options = {})
               prefix: '@',
               enum_method: :users_list,
               list_method: :members,
-              options: { limit: limit }
+              options: { limit: limit }.compact
             )
           end
         end

lib/slack/web/config.rb

@@ -34,8 +34,8 @@ def reset
         self.timeout = nil
         self.open_timeout = nil
         self.default_page_size = 100
-        self.conversations_id_page_size = default_page_size
-        self.users_id_page_size = default_page_size
+        self.conversations_id_page_size = nil
+        self.users_id_page_size = nil
         self.default_max_retries = 100
         self.adapter = ::Faraday.default_adapter
       end

spec/slack/web/api/mixins/conversations_spec.rb

@@ -31,7 +31,7 @@
     end
 
     it 'translates a channel that starts with a #' do
-      expect(conversations).to receive(:conversations_list).with(limit: 100)
+      expect(conversations).to receive(:conversations_list).with(no_args)
       expect(conversations.conversations_id(channel: '#general')).to(
         eq('ok' => true, 'channel' => { 'id' => 'CDEADBEEF' })
       )

spec/slack/web/api/mixins/users_spec.rb

@@ -30,7 +30,7 @@
     end
 
     it 'translates a user that starts with a @' do
-      expect(users).to receive(:users_list).with(limit: 100)
+      expect(users).to receive(:users_list).with(no_args)
       expect(users.users_id(user: '@aws')).to eq('ok' => true, 'user' => { 'id' => 'UDEADBEEF' })
     end