Fix: do not attempt to resolve channel name for APIs that support it.

Author: dblock

lib/slack/web/api/endpoints/chat.rb

@@ -173,7 +173,6 @@ def chat_postEphemeral(options = {})
           def chat_postMessage(options = {})
             raise ArgumentError, 'Required arguments :channel missing' if options[:channel].nil?
             raise ArgumentError, 'At least one of :attachments, :blocks, :text is required' if options[:attachments].nil? && options[:blocks].nil? && options[:text].nil?
-            options = options.merge(channel: conversations_id(options)['channel']['id']) if options[:channel]
             options = encode_options_as_json(options, %i[attachments blocks metadata])
             post('chat.postMessage', options)
           end

lib/slack/web/api/templates/method.erb

@@ -48,7 +48,7 @@ module Slack
 <% end %>
 <% if data['group'] == 'groups' && data['args']['channel'] && !data['args']['channel']['desc'].include?('Can be an encoded ID, or a name.') %>
             options = options.merge(channel: groups_id(options)['group']['id']) if options[:channel]
-<% elsif data['args']['channel'] && !data['args']['channel']['desc'].include?('Can be an encoded ID, or a name.') %>
+<% elsif data['args']['channel'] && ['Can be an encoded ID, or a name.', 'encoded ID or channel name'].none? { |desc| data['args']['channel']['desc'].include?(desc) } %>
             options = options.merge(channel: conversations_id(options)['channel']['id']) if options[:channel]
 <% end %>
 <% if data['args']['user'] %>

spec/slack/web/api/endpoints/custom/chat_spec.rb

@@ -92,6 +92,18 @@
   end
 
   context 'chat_postMessage' do
+    it 'does not convert channel name to channel ID' do
+      expect(client).not_to receive(:conversations_id)
+      expect(client).to receive(:post).with(
+        'chat.postMessage',
+        {
+          channel: '#channel',
+          text: 'text'
+        }
+      )
+      client.chat_postMessage(channel: '#channel', text: 'text')
+    end
+
     it 'automatically converts attachments and blocks into JSON' do
       expect(client).to receive(:post).with(
         'chat.postMessage',

spec/slack/web/api/endpoints/custom/conversations_spec.rb

@@ -10,4 +10,19 @@
       expect(json.channel.name).to eq 'mpdm-dblock--rubybot--player1-1'
     end
   end
+
+  context 'list' do
+    it 'resolves channel and includes all arguments into http requests' do
+      expect(client).to receive(:conversations_list).and_yield(
+        Slack::Messages::Message.new(
+          'channels' => [{
+            'id' => 'CDEADBEEF',
+            'name' => 'general'
+          }]
+        )
+      )
+      expect(client).to receive(:post).with('conversations.history', { channel: 'CDEADBEEF', limit: 10 })
+      client.conversations_history(channel: '#general', limit: 10)
+    end
+  end
 end