Skip to content

Commit 64810fd

Browse files
committed
Removed deprecated methods from specs.
1 parent 435767e commit 64810fd

File tree

6 files changed

+21
-46
lines changed

6 files changed

+21
-46
lines changed

lib/tasks/web.rake

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,10 @@ namespace :slack do
3232
parsed = JSON.parse(File.read(path))
3333
parsed['undocumented'] = true if path =~ /undocumented/
3434
JSON::Validator.validate(method_schema, parsed, insert_defaults: true)
35-
next if parsed['deprecated'] && parsed['deprecation']['deprecation_warning'] =~ /It will stop functioning in February 2021/
35+
if parsed['deprecated'] && parsed['deprecation']['deprecation_warning'] =~ /It will stop functioning in February 2021/
36+
next
37+
end
38+
3639
result[prefix][name] = parsed
3740
end
3841

spec/fixtures/slack/web/groups_info.yml renamed to spec/fixtures/slack/web/conversations_info.yml

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

spec/slack/web/api/endpoints/custom_specs/channels_spec.rb

Lines changed: 0 additions & 13 deletions
This file was deleted.
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# frozen_string_literal: true
2+
require 'spec_helper'
3+
4+
RSpec.describe Slack::Web::Api::Endpoints::Groups do
5+
let(:client) { Slack::Web::Client.new }
6+
7+
context 'groups' do
8+
it 'info', vcr: { cassette_name: 'web/conversations_info' } do
9+
json = client.conversations_info(channel: '#mpdm-dblock--rubybot--player1-1')
10+
expect(json.channel.name).to eq 'mpdm-dblock--rubybot--player1-1'
11+
end
12+
end
13+
end

spec/slack/web/api/endpoints/custom_specs/groups_spec.rb

Lines changed: 0 additions & 13 deletions
This file was deleted.

spec/slack/web/client_spec.rb

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -250,21 +250,6 @@
250250
end
251251
end
252252

253-
context 'when calling deprecated methods' do
254-
let(:client) { described_class.new }
255-
256-
it 'produces a warning' do
257-
expect(client.logger).to receive(:warn).with(/
258-
^channels\.archive:\ This\ method\ is\ deprecated
259-
.+
260-
Alternative\ methods:\ conversations\.archive\.
261-
/x)
262-
263-
expect(client).to receive(:post)
264-
client.channels_archive(channel: 'test')
265-
end
266-
end
267-
268253
context 'persistent capability' do
269254
describe '#initialize' do
270255
it 'caches the Faraday connection to allow persistent adapters' do

0 commit comments

Comments
 (0)