PR feedback - flip logic, rename methods

Author: gregsaab

lib/slack/web/faraday/request.rb

@@ -28,12 +28,12 @@ def request(method, path, options)
               request.url(path, options)
             when :post, :put
               request.path = path
-              options.compact! unless options.is_a? String
+              options.compact! if options.respond_to? :compact
               request.body = options unless options.empty?
             end
             request.headers['Authorization'] = "Bearer #{token}" if token
 
-            request.options.merge!(options.delete(:request)) if !options.is_a?(String) && options.key?(:request)
+            request.options.merge!(options.delete(:request)) if options.respond_to?(:key) && options.key?(:request)
           end
           response.body
         rescue ::Faraday::ParsingError => e

lib/slack/web/faraday/response/raise_error.rb

@@ -4,12 +4,12 @@ module Web
     module Faraday
       module Response
         class RaiseError < ::Faraday::Middleware
-          def throw_if_too_many_requests(env)
+          def raise_if_too_many_requests!(env)
             raise Slack::Web::Api::Errors::TooManyRequestsError, env.response if env.status == 429
           end
 
-          def throw_if_response_is_invalid_json(env)
-            return unless !response_content_type_is_a_string?(env) && !env.body.is_a?(Hash)
+          def raise_if_response_is_invalid_json!(env)
+            return if response_content_type_is_a_string?(env) || env.body.is_a?(Hash)
 
             raise ::Faraday::ParsingError.new(nil, env.response)
           end
@@ -28,8 +28,8 @@ def should_return?(env)
           end
 
           def on_complete(env)
-            throw_if_too_many_requests(env)
-            throw_if_response_is_invalid_json(env)
+            raise_if_too_many_requests!(env)
+            raise_if_response_is_invalid_json!(env)
 
             body = env.body
             return if should_return?(env)