Skip to content

Commit 6eed16a

Browse files
committed
Removed support for legacy RTM.
1 parent c4a1fe9 commit 6eed16a

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+70
-4774
lines changed

.github/workflows/integration_test.yml

Lines changed: 0 additions & 45 deletions
This file was deleted.

.github/workflows/test.yml

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,17 @@ jobs:
77
matrix:
88
entry:
99
- { ruby: "2.7" }
10-
- { ruby: "2.7", concurrency: async-websocket }
1110
- { ruby: "3.0" }
1211
- { ruby: "3.1" }
1312
- { ruby: "3.2" }
1413
- { ruby: "3.3" }
1514
- { ruby: "3.4" }
1615
- { ruby: ruby-head, ignore: true }
1716
- { ruby: jruby-head, ignore: true }
18-
name: test (ruby=${{ matrix.entry.ruby }}${{ matrix.entry.concurrency && ', concurrency=' }}${{ matrix.entry.concurrency }})
17+
name: test (ruby=${{ matrix.entry.ruby }})
1918
steps:
2019
- name: Checkout
2120
uses: actions/checkout@v4
22-
- name: Set Concurrency
23-
run: |
24-
if [[ ! -z "${{ matrix.entry.concurrency }}" ]]; then
25-
echo "Setting concurrency to ${{ matrix.entry.concurrency }}."
26-
echo "CONCURRENCY=${{ matrix.entry.concurrency }}" >> $GITHUB_ENV
27-
fi
2821
- name: Set up Ruby
2922
uses: ruby/setup-ruby@v1
3023
with:
@@ -41,7 +34,7 @@ jobs:
4134
with:
4235
parallel: true
4336
github-token: ${{ secrets.GITHUB_TOKEN }}
44-
flag-name: run-${{ matrix.entry.ruby }}${{ matrix.entry.concurrency && '-'}}${{ matrix.entry.concurrency }}
37+
flag-name: run-${{ matrix.entry.ruby }}
4538
allow-empty: ${{ matrix.entry.ignore || false }}
4639

4740
finish:
@@ -53,4 +46,4 @@ jobs:
5346
uses: coverallsapp/github-action@v2
5447
with:
5548
parallel-finished: true
56-
carryforward: 'run-2.7,run-2.7-async-websocket,run-3.0,run-3.1,run-3.2,run-3.3'
49+
carryforward: 'run-2.7,run-2.7-async-websocket,run-3.0,run-3.1,run-3.2,run-3.3,run-3.4'

.rubocop_todo.yml

Lines changed: 45 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,11 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2025-07-19 11:04:04 UTC using RuboCop version 1.26.1.
3+
# on 2025-09-21 17:08:14 UTC using RuboCop version 1.26.1.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
77
# versions of RuboCop, may require this file to be generated again.
88

9-
# Offense count: 1
10-
# Configuration parameters: AllowedMethods.
11-
# AllowedMethods: enums
12-
Lint/ConstantDefinitionInBlock:
13-
Exclude:
14-
- 'lib/tasks/real_time.rake'
15-
16-
# Offense count: 2
17-
# Configuration parameters: AllowComments, AllowEmptyLambdas.
18-
Lint/EmptyBlock:
19-
Exclude:
20-
- 'spec/slack/real_time/concurrency/clients/async_spec.rb'
21-
- 'spec/support/real_time/concurrency/mock.rb'
22-
23-
# Offense count: 1
24-
# Configuration parameters: AllowComments.
25-
Lint/EmptyClass:
26-
Exclude:
27-
- 'spec/support/real_time/concurrency/mock.rb'
28-
29-
# Offense count: 2
30-
Lint/MissingSuper:
31-
Exclude:
32-
- 'lib/slack/real_time/stores/starter.rb'
33-
- 'lib/slack/real_time/stores/store.rb'
34-
359
# Offense count: 1
3610
# This cop supports unsafe auto-correction (--auto-correct-all).
3711
Lint/NonDeterministicRequireOrder:
@@ -44,17 +18,17 @@ Lint/RedundantCopDisableDirective:
4418
Exclude:
4519
- 'lib/slack-ruby-client.rb'
4620

47-
# Offense count: 13
21+
# Offense count: 7
4822
# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
4923
Metrics/AbcSize:
5024
Max: 67
5125

52-
# Offense count: 6
26+
# Offense count: 4
5327
# Configuration parameters: IgnoredMethods.
5428
Metrics/CyclomaticComplexity:
5529
Max: 15
5630

57-
# Offense count: 17
31+
# Offense count: 10
5832
# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
5933
Metrics/MethodLength:
6034
Max: 45
@@ -64,7 +38,7 @@ Metrics/MethodLength:
6438
Metrics/ParameterLists:
6539
Max: 6
6640

67-
# Offense count: 3
41+
# Offense count: 2
6842
# Configuration parameters: IgnoredMethods.
6943
Metrics/PerceivedComplexity:
7044
Max: 17
@@ -88,7 +62,7 @@ Performance/RegexpMatch:
8862
Exclude:
8963
- 'lib/tasks/web.rake'
9064

91-
# Offense count: 3
65+
# Offense count: 2
9266
# This cop supports safe auto-correction (--auto-correct).
9367
Performance/StringInclude:
9468
Exclude:
@@ -101,30 +75,55 @@ RSpec/ContextMethod:
10175
- 'spec/slack/messages/formatting_spec.rb'
10276
- 'spec/slack/web/api/mixins/users_spec.rb'
10377

104-
# Offense count: 86
78+
# Offense count: 59
10579
# Configuration parameters: Prefixes.
10680
# Prefixes: when, with, without
10781
RSpec/ContextWording:
108-
Enabled: false
82+
Exclude:
83+
- 'spec/slack/events/config_spec.rb'
84+
- 'spec/slack/events/request_spec.rb'
85+
- 'spec/slack/messages/formatting_spec.rb'
86+
- 'spec/slack/slack_spec.rb'
87+
- 'spec/slack/web/api/endpoints/custom/auth_spec.rb'
88+
- 'spec/slack/web/api/endpoints/custom/chat_spec.rb'
89+
- 'spec/slack/web/api/endpoints/custom/conversations_spec.rb'
90+
- 'spec/slack/web/api/endpoints/custom/dialog_spec.rb'
91+
- 'spec/slack/web/api/endpoints/custom/users_spec.rb'
92+
- 'spec/slack/web/api/mixins/conversations_list_spec.rb'
93+
- 'spec/slack/web/api/mixins/users_spec.rb'
94+
- 'spec/slack/web/api/options_spec.rb'
95+
- 'spec/slack/web/api/pagination/cursor_spec.rb'
96+
- 'spec/slack/web/client_spec.rb'
97+
- 'spec/slack/web/faraday/request_spec.rb'
10998

110-
# Offense count: 75
99+
# Offense count: 35
111100
# Configuration parameters: CountAsOne.
112101
RSpec/ExampleLength:
113-
Max: 18
102+
Max: 17
114103

115-
# Offense count: 19
104+
# Offense count: 10
116105
# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
117106
# Include: **/*_spec*rb*, **/spec/**/*
118107
RSpec/FilePath:
119-
Enabled: false
108+
Exclude:
109+
- 'spec/slack/version_spec.rb'
110+
- 'spec/slack/web/api/endpoints/custom/auth_spec.rb'
111+
- 'spec/slack/web/api/endpoints/custom/chat_spec.rb'
112+
- 'spec/slack/web/api/endpoints/custom/conversations_spec.rb'
113+
- 'spec/slack/web/api/endpoints/custom/dialog_spec.rb'
114+
- 'spec/slack/web/api/endpoints/custom/files_spec.rb'
115+
- 'spec/slack/web/api/endpoints/custom/users_spec.rb'
116+
- 'spec/slack/web/api/endpoints/custom/views_spec.rb'
117+
- 'spec/slack/web/api/mixins/conversations_list_spec.rb'
118+
- 'spec/slack/web/api/options_spec.rb'
120119

121-
# Offense count: 86
120+
# Offense count: 66
122121
# Configuration parameters: .
123122
# SupportedStyles: have_received, receive
124123
RSpec/MessageSpies:
125124
EnforcedStyle: receive
126125

127-
# Offense count: 103
126+
# Offense count: 65
128127
RSpec/MultipleExpectations:
129128
Max: 5
130129

@@ -139,15 +138,13 @@ RSpec/NamedSubject:
139138
Exclude:
140139
- 'spec/slack/web/api/mixins/conversations_list_spec.rb'
141140

142-
# Offense count: 48
141+
# Offense count: 26
143142
RSpec/NestedGroups:
144-
Max: 6
143+
Max: 5
145144

146-
# Offense count: 6
145+
# Offense count: 3
147146
RSpec/StubbedMock:
148147
Exclude:
149-
- 'spec/slack/real_time/client_spec.rb'
150-
- 'spec/slack/real_time/event_handlers/event_handlers_spec.rb'
151148
- 'spec/slack/web/api/endpoints/custom/conversations_spec.rb'
152149
- 'spec/slack/web/api/pagination/cursor_spec.rb'
153150
- 'spec/slack/web/client_spec.rb'
@@ -165,41 +162,30 @@ RSpec/SubjectStub:
165162
RSpec/VerifiedDoubleReference:
166163
EnforcedStyle: string
167164

168-
# Offense count: 10
165+
# Offense count: 2
169166
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
170167
RSpec/VerifiedDoubles:
171168
Exclude:
172169
- 'spec/slack/events/request_spec.rb'
173-
- 'spec/slack/real_time/client_spec.rb'
174170
- 'spec/slack/web/faraday/response/raise_error_spec.rb'
175-
- 'spec/support/real_time/connected_client.rb'
176171

177172
# Offense count: 1
178173
# This cop supports safe auto-correction (--auto-correct).
179174
Rake/Desc:
180175
Exclude:
181176
- 'lib/tasks/git.rake'
182177

183-
# Offense count: 1
184-
# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
185-
# SupportedStyles: inline, group
186-
Style/AccessModifierDeclarations:
187-
Exclude:
188-
- 'lib/slack/real_time/client.rb'
189-
190178
# Offense count: 4
191179
# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
192180
# SupportedStyles: annotated, template, unannotated
193181
Style/FormatStringToken:
194182
EnforcedStyle: unannotated
195183

196-
# Offense count: 5
184+
# Offense count: 2
197185
# This cop supports safe auto-correction (--auto-correct).
198186
Style/GlobalStdStream:
199187
Exclude:
200188
- 'lib/slack/logger.rb'
201-
- 'lib/tasks/real_time.rake'
202-
- 'spec/integration/integration_spec.rb'
203189
- 'spec/slack/web/client_spec.rb'
204190

205191
# Offense count: 1
@@ -219,19 +205,11 @@ Style/MultilineTernaryOperator:
219205
Exclude:
220206
- 'spec/support/vcr.rb'
221207

222-
# Offense count: 3
208+
# Offense count: 2
223209
Style/OpenStructUse:
224210
Exclude:
225211
- 'spec/slack/web/api/endpoints/custom/chat_spec.rb'
226212
- 'spec/slack/web/api/pagination/cursor_spec.rb'
227-
- 'spec/slack/web/faraday/response/raise_error_spec.rb'
228-
229-
# Offense count: 1
230-
# Configuration parameters: AllowedMethods.
231-
# AllowedMethods: respond_to_missing?
232-
Style/OptionalBooleanParameter:
233-
Exclude:
234-
- 'spec/support/queue_with_timeout.rb'
235213

236214
# Offense count: 1
237215
# This cop supports safe auto-correction (--auto-correct).

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
### 2.7.1 (Next)
1+
### 3.0.0 (Next)
22

3+
* [#573](https://github.com/slack-ruby/slack-ruby-client/pull/573) Removed support for RTM APIs - [@dblock](https://github.com/dblock).
34
* [#568](https://github.com/slack-ruby/slack-ruby-client/pull/568): Redact Authorization header in response stored in the error - [@levenleven](https://github.com/levenleven).
4-
55
* [#558](https://github.com/slack-ruby/slack-ruby-client/pull/558): Update API from [slack-api-ref@c408935](https://github.com/slack-ruby/slack-api-ref/commit/c408935) - [@slack-ruby-ci-bot](https://github.com/apps/slack-ruby-ci-bot).
66
* [#571](https://github.com/slack-ruby/slack-ruby-client/pull/571): Update API from [slack-api-ref@e1a2c4d](https://github.com/slack-ruby/slack-api-ref/commit/e1a2c4d) - [@slack-ruby-ci-bot](https://github.com/apps/slack-ruby-ci-bot).
77
* Your contribution here.

Gemfile

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,6 @@ source 'http://rubygems.org'
33

44
gemspec
55

6-
if ENV.key?('CONCURRENCY')
7-
case ENV['CONCURRENCY']
8-
when 'async-websocket'
9-
gem 'async-websocket', '~> 0.8.0', require: false
10-
else
11-
gem ENV['CONCURRENCY'], require: false
12-
end
13-
end
14-
156
group :test do
167
gem 'activesupport'
178
gem 'base64'

0 commit comments

Comments
 (0)