Translate #channel in file upload.

Author: dblock

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-02-05 16:58:54 UTC using RuboCop version 1.26.1.
+# on 2025-02-08 14:45:33 UTC using RuboCop version 1.26.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -47,7 +47,7 @@ Lint/RedundantCopDisableDirective:
 # Offense count: 13
 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 34
+  Max: 38
 
 # Offense count: 5
 # Configuration parameters: IgnoredMethods.

lib/slack/web/api/helpers/files.rb

@@ -32,6 +32,7 @@ def files_upload_v2(params = {})
               raise ArgumentError, "Required argument :#{param} missing" if params[param].nil?
             end
 
+            channel = conversations_id(channel: params[:channels])['channel']['id']
             content = params[:content]
             title = params[:title] || params[:filename]
 
@@ -55,7 +56,8 @@ def files_upload_v2(params = {})
             end
 
             # Complete the upload.
-            complete_upload_request_params = params.slice(:channels, :initial_comment, :thread_ts)
+            complete_upload_request_params = params.slice(:initial_comment, :thread_ts)
+            complete_upload_request_params[:channels] = channel
             complete_upload_request_params[:files] = [{ id: file_id, title: title }].to_json
 
             files_completeUploadExternal(complete_upload_request_params)

spec/fixtures/slack/web/files_upload_v2_with_channel_name.yml

@@ -36,6 +36,27 @@
     end
   end
 
+  context 'when a channel is referenced by name', vcr: { cassette_name: 'web/files_upload_v2_with_channel_name' } do
+    before do
+      allow(client).to receive(:conversations_list).and_yield(
+        Slack::Messages::Message.new(
+          'channels' => [{
+            'id' => 'C08AZ76CA4V',
+            'name' => 'general'
+          }]
+        )
+      )
+    end
+
+    it 'translates the channel name to an ID and completes the upload' do
+      expect(client.files_upload_v2(
+        filename: 'test.txt',
+        content: 'Test File Contents',
+        channels: '#general'
+      ).files.size).to eq 1
+    end
+  end
+
   context 'when using a list for channels', vcr: { cassette_name: 'web/files_upload_v2_with_channels_list' } do
     it 'completes the upload' do
       expect(client.files_upload_v2(

spec/slack/web/api/endpoints/custom_specs/files_spec.rb

@@ -29,7 +29,7 @@
       expect(users.users_id(user: 'U123456')).to eq('ok' => true, 'user' => { 'id' => 'U123456' })
     end
 
-    it 'translates a user that starts with a #' do
+    it 'translates a user that starts with a @' do
       expect(users.users_id(user: '@aws')).to eq('ok' => true, 'user' => { 'id' => 'UDEADBEEF' })
     end