fix tests

monkeyWzr · monkeyWzr · commit 7ef66c9e7070 · 2025-01-16T02:55:15.000+09:00
diff --git a/lib/slack/web/faraday/connection.rb b/lib/slack/web/faraday/connection.rb
@@ -9,7 +9,7 @@ def connection
           @connection ||=
             begin
               options = {
-                headers: { 'Accept' => 'application/json, text/plain; charset=utf-8' }
+                headers: { 'Accept' => 'application/json; charset=utf-8, text/plain; charset=utf-8' }
               }
 
               options[:headers]['User-Agent'] = user_agent if user_agent
@@ -26,7 +26,7 @@ def connection
                 connection.request :url_encoded
                 connection.use ::Slack::Web::Faraday::Response::RaiseError
                 connection.response :mashify, mash_class: Slack::Messages::Message
-                connection.response :json, content_type: /\b*json$/
+                connection.response :json, content_type: /\bjson$/
                 connection.use ::Slack::Web::Faraday::Response::WrapError
                 connection.response :logger, logger if logger
                 connection.adapter adapter
diff --git a/spec/fixtures/slack/web/rtm_connect.yml b/spec/fixtures/slack/web/rtm_connect.yml
diff --git a/spec/slack/web/client_spec.rb b/spec/slack/web/client_spec.rb
@@ -60,7 +60,7 @@
 
         it 'creates a connection with the custom user-agent' do
           expect(client.send(:connection).headers).to eq(
-            'Accept' => 'application/json; charset=utf-8',
+            'Accept' => 'application/json, text/plain; charset=utf-8',
             'User-Agent' => 'custom/user-agent'
           )
         end
@@ -286,19 +286,6 @@
       end
 
       context 'parsing error' do
-        context 'when the response is not JSON' do
-          before do
-            stub_slack_request.to_return(body: '<html></html>', headers: { 'Content-Type' => 'text/html' })
-          end
-
-          it 'raises ParsingError' do
-            expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
-            expect(exception.response.body).to eq('<html></html>')
-            expect(exception.cause).to be_a(Faraday::ParsingError)
-            expect(exception.cause.cause).to be_a(JSON::ParserError)
-          end
-        end
-
         context 'when the response is malformed JSON' do
           before { stub_slack_request.to_return(body: '{') }
 
