Tests for default id_for page sizes

Author: eizengan

spec/slack/web/api/mixins/conversations_spec.rb

@@ -13,7 +13,7 @@
   end
 
   before do
-    allow(conversations).to receive(:conversations_id_page_size).and_return(100)
+    allow(conversations).to receive(:conversations_id_page_size) { Slack::Web.config.conversations_id_page_size }
     allow(conversations).to receive(:conversations_list).and_yield(
       Slack::Messages::Message.new(
         'channels' => [{
@@ -32,6 +32,7 @@
     end
 
     it 'translates a channel that starts with a #' do
+      expect(conversations).to receive(:conversations_list).with(limit: 100)
       expect(conversations.conversations_id(channel: '#general')).to(
         eq('ok' => true, 'channel' => { 'id' => 'CDEADBEEF' })
       )
@@ -47,5 +48,22 @@
         raise_error(Slack::Web::Api::Errors::SlackError, 'channel_not_found')
       )
     end
+
+    context "when a non-default conversations_id page size has been configured" do
+      before { Slack::Web.config.conversations_id_page_size = 500 }
+      after { Slack::Web.config.reset }
+
+      it 'translates a channel that starts with a #' do
+        expect(conversations).to receive(:conversations_list).with(limit: 500)
+        expect(conversations.conversations_id(channel: '#general')).to(
+          eq('ok' => true, 'channel' => { 'id' => 'CDEADBEEF' })
+        )
+      end
+
+      it 'forwards a provided limit to the underlying conversations_list calls' do
+        expect(conversations).to receive(:conversations_list).with(limit: 1234)
+        conversations.conversations_id(channel: '#general', limit: 1234)
+      end
+    end
   end
 end

spec/slack/web/api/mixins/users_spec.rb

@@ -13,7 +13,7 @@
   end
 
   before do
-    allow(users).to receive(:users_id_page_size).and_return(100)
+    allow(users).to receive(:users_id_page_size) { Slack::Web.config.users_id_page_size }
     allow(users).to receive(:users_list).and_yield(
       Slack::Messages::Message.new(
         'members' => [{
@@ -31,6 +31,7 @@
     end
 
     it 'translates a user that starts with a @' do
+      expect(users).to receive(:users_list).with(limit: 100)
       expect(users.users_id(user: '@aws')).to eq('ok' => true, 'user' => { 'id' => 'UDEADBEEF' })
     end
 
@@ -44,6 +45,21 @@
         raise_error(Slack::Web::Api::Errors::SlackError, 'user_not_found')
       )
     end
+
+    context "when a non-default conversations_id page size has been configured" do
+      before { Slack::Web.config.users_id_page_size = 500 }
+      after { Slack::Web.config.reset }
+
+      it 'translates a user that starts with a @' do
+        expect(users).to receive(:users_list).with(limit: 500)
+        expect(users.users_id(user: '@aws')).to eq('ok' => true, 'user' => { 'id' => 'UDEADBEEF' })
+      end
+
+      it 'forwards a provided limit to the underlying users_list calls' do
+        expect(users).to receive(:users_list).with(limit: 1234)
+        users.users_id(user: '@aws', limit: 1234)
+      end
+    end
   end
 
   if defined?(Picky)