Skip to content

Commit 89fea6d

Browse files
committed
Disable BlockLength, more restrictive rubocop_todo.yml
1 parent 33706d4 commit 89fea6d

File tree

2 files changed

+127
-13
lines changed

2 files changed

+127
-13
lines changed

.rubocop_todo.yml

Lines changed: 126 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This configuration was generated by
2-
# `rubocop --auto-gen-config`
3-
# on 2019-07-31 18:27:48 -0700 using RuboCop version 0.73.0.
2+
# `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 100`
3+
# on 2019-08-01 15:06:19 -0700 using RuboCop version 0.73.0.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
@@ -23,21 +23,45 @@ Lint/HandleExceptions:
2323
- 'spec/slack/real_time/concurrency/eventmachine_spec.rb'
2424

2525
# Offense count: 9
26+
# Configuration parameters: Max.
2627
Metrics/AbcSize:
27-
Max: 39
28+
Exclude:
29+
- 'lib/slack/real_time/client.rb'
30+
- 'lib/slack/real_time/concurrency/async.rb'
31+
- 'lib/slack/real_time/stores/store.rb'
32+
- 'lib/slack/web/api/mixins/users.search.rb'
33+
- 'lib/slack/web/faraday/connection.rb'
34+
- 'lib/slack/web/pagination/cursor.rb'
35+
- 'spec/integration/integration_spec.rb'
2836

2937
# Offense count: 1
38+
# Configuration parameters: Max.
3039
Metrics/CyclomaticComplexity:
31-
Max: 9
40+
Exclude:
41+
- 'lib/slack/web/faraday/connection.rb'
3242

3343
# Offense count: 13
34-
# Configuration parameters: CountComments, ExcludedMethods.
44+
# Configuration parameters: CountComments, Max, ExcludedMethods.
3545
Metrics/MethodLength:
36-
Max: 32
46+
Exclude:
47+
- 'lib/slack/messages/formatting.rb'
48+
- 'lib/slack/real_time/client.rb'
49+
- 'lib/slack/real_time/concurrency/async.rb'
50+
- 'lib/slack/real_time/concurrency/celluloid.rb'
51+
- 'lib/slack/real_time/config.rb'
52+
- 'lib/slack/real_time/stores/store.rb'
53+
- 'lib/slack/web/api/mixins/users.search.rb'
54+
- 'lib/slack/web/config.rb'
55+
- 'lib/slack/web/faraday/connection.rb'
56+
- 'lib/slack/web/faraday/request.rb'
57+
- 'lib/slack/web/pagination/cursor.rb'
58+
- 'spec/integration/integration_spec.rb'
3759

3860
# Offense count: 1
61+
# Configuration parameters: Max.
3962
Metrics/PerceivedComplexity:
40-
Max: 9
63+
Exclude:
64+
- 'lib/slack/web/faraday/connection.rb'
4165

4266
# Offense count: 1
4367
# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
@@ -62,7 +86,32 @@ RSpec/AnyInstance:
6286
# Configuration parameters: Prefixes.
6387
# Prefixes: when, with, without
6488
RSpec/ContextWording:
65-
Enabled: false
89+
Exclude:
90+
- 'spec/integration/integration_spec.rb'
91+
- 'spec/slack/events/config_spec.rb'
92+
- 'spec/slack/events/request_spec.rb'
93+
- 'spec/slack/messages/formatting_spec.rb'
94+
- 'spec/slack/real_time/client_spec.rb'
95+
- 'spec/slack/real_time/concurrency/celluloid_spec.rb'
96+
- 'spec/slack/real_time/event_handlers/bot_spec.rb'
97+
- 'spec/slack/real_time/event_handlers/channel_spec.rb'
98+
- 'spec/slack/real_time/event_handlers/group_spec.rb'
99+
- 'spec/slack/real_time/event_handlers/im_spec.rb'
100+
- 'spec/slack/real_time/event_handlers/team_spec.rb'
101+
- 'spec/slack/real_time/event_handlers/user_spec.rb'
102+
- 'spec/slack/slack_spec.rb'
103+
- 'spec/slack/web/api/endpoints/custom_specs/auth_spec.rb'
104+
- 'spec/slack/web/api/endpoints/custom_specs/channels_spec.rb'
105+
- 'spec/slack/web/api/endpoints/custom_specs/chat_spec.rb'
106+
- 'spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb'
107+
- 'spec/slack/web/api/endpoints/custom_specs/groups_spec.rb'
108+
- 'spec/slack/web/api/endpoints/custom_specs/users_spec.rb'
109+
- 'spec/slack/web/api/mixins/channels_spec.rb'
110+
- 'spec/slack/web/api/mixins/groups_spec.rb'
111+
- 'spec/slack/web/api/mixins/users_spec.rb'
112+
- 'spec/slack/web/api/pagination/cursor_spec.rb'
113+
- 'spec/slack/web/client_spec.rb'
114+
- 'spec/support/real_time/connected_client.rb'
66115

67116
# Offense count: 1
68117
RSpec/DescribeClass:
@@ -90,7 +139,27 @@ RSpec/EmptyLineAfterFinalLet:
90139
# Offense count: 63
91140
# Configuration parameters: Max.
92141
RSpec/ExampleLength:
93-
Enabled: false
142+
Exclude:
143+
- 'spec/integration/integration_spec.rb'
144+
- 'spec/slack/real_time/client_spec.rb'
145+
- 'spec/slack/real_time/event_handlers/bot_spec.rb'
146+
- 'spec/slack/real_time/event_handlers/channel_spec.rb'
147+
- 'spec/slack/real_time/event_handlers/event_handlers_spec.rb'
148+
- 'spec/slack/real_time/event_handlers/group_spec.rb'
149+
- 'spec/slack/real_time/event_handlers/im_spec.rb'
150+
- 'spec/slack/real_time/event_handlers/team_spec.rb'
151+
- 'spec/slack/real_time/event_handlers/user_spec.rb'
152+
- 'spec/slack/slack_spec.rb'
153+
- 'spec/slack/web/api/endpoints/custom_specs/auth_spec.rb'
154+
- 'spec/slack/web/api/endpoints/custom_specs/chat_spec.rb'
155+
- 'spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb'
156+
- 'spec/slack/web/api/endpoints/custom_specs/users_spec.rb'
157+
- 'spec/slack/web/api/error_spec.rb'
158+
- 'spec/slack/web/api/errors/service_unavailable_spec.rb'
159+
- 'spec/slack/web/api/errors/slack_error_spec.rb'
160+
- 'spec/slack/web/api/pagination/cursor_spec.rb'
161+
- 'spec/slack/web/client_spec.rb'
162+
- 'spec/slack/web/faraday/response/raise_error_spec.rb'
94163

95164
# Offense count: 2
96165
RSpec/ExpectInHook:
@@ -100,7 +169,23 @@ RSpec/ExpectInHook:
100169
# Offense count: 16
101170
# Configuration parameters: CustomTransform, IgnoreMethods.
102171
RSpec/FilePath:
103-
Enabled: false
172+
Exclude:
173+
- 'spec/slack/real_time/api/message_spec.rb'
174+
- 'spec/slack/real_time/api/ping_spec.rb'
175+
- 'spec/slack/real_time/api/typing_spec.rb'
176+
- 'spec/slack/real_time/event_handlers/bot_spec.rb'
177+
- 'spec/slack/real_time/event_handlers/channel_spec.rb'
178+
- 'spec/slack/real_time/event_handlers/event_handlers_spec.rb'
179+
- 'spec/slack/real_time/event_handlers/group_spec.rb'
180+
- 'spec/slack/real_time/event_handlers/im_spec.rb'
181+
- 'spec/slack/real_time/event_handlers/user_spec.rb'
182+
- 'spec/slack/web/api/endpoints/custom_specs/auth_spec.rb'
183+
- 'spec/slack/web/api/endpoints/custom_specs/channels_spec.rb'
184+
- 'spec/slack/web/api/endpoints/custom_specs/chat_spec.rb'
185+
- 'spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb'
186+
- 'spec/slack/web/api/endpoints/custom_specs/groups_spec.rb'
187+
- 'spec/slack/web/api/endpoints/custom_specs/users_spec.rb'
188+
- 'spec/slack/web/api/errors/service_unavailable_spec.rb'
104189

105190
# Offense count: 1
106191
# Cop supports --auto-correct.
@@ -125,9 +210,33 @@ RSpec/MessageSpies:
125210
EnforcedStyle: receive
126211

127212
# Offense count: 92
128-
# Configuration parameters: AggregateFailuresByDefault.
213+
# Configuration parameters: Max, AggregateFailuresByDefault.
129214
RSpec/MultipleExpectations:
130-
Max: 5
215+
Exclude:
216+
- 'spec/integration/integration_spec.rb'
217+
- 'spec/slack/events/config_spec.rb'
218+
- 'spec/slack/events/request_spec.rb'
219+
- 'spec/slack/real_time/client_spec.rb'
220+
- 'spec/slack/real_time/concurrency/celluloid_spec.rb'
221+
- 'spec/slack/real_time/concurrency/eventmachine_spec.rb'
222+
- 'spec/slack/real_time/event_handlers/bot_spec.rb'
223+
- 'spec/slack/real_time/event_handlers/channel_spec.rb'
224+
- 'spec/slack/real_time/event_handlers/event_handlers_spec.rb'
225+
- 'spec/slack/real_time/event_handlers/group_spec.rb'
226+
- 'spec/slack/real_time/event_handlers/im_spec.rb'
227+
- 'spec/slack/real_time/event_handlers/team_spec.rb'
228+
- 'spec/slack/real_time/event_handlers/user_spec.rb'
229+
- 'spec/slack/real_time/store_spec.rb'
230+
- 'spec/slack/slack_spec.rb'
231+
- 'spec/slack/web/api/endpoints/custom_specs/auth_spec.rb'
232+
- 'spec/slack/web/api/endpoints/custom_specs/chat_spec.rb'
233+
- 'spec/slack/web/api/endpoints/custom_specs/dialog_spec.rb'
234+
- 'spec/slack/web/api/endpoints/custom_specs/users_spec.rb'
235+
- 'spec/slack/web/api/error_spec.rb'
236+
- 'spec/slack/web/api/errors/service_unavailable_spec.rb'
237+
- 'spec/slack/web/api/errors/slack_error_spec.rb'
238+
- 'spec/slack/web/api/pagination/cursor_spec.rb'
239+
- 'spec/slack/web/client_spec.rb'
131240

132241
# Offense count: 53
133242
# Configuration parameters: IgnoreSharedExamples.
@@ -141,8 +250,12 @@ RSpec/NamedSubject:
141250
- 'spec/slack/web/faraday/response/raise_error_spec.rb'
142251

143252
# Offense count: 32
253+
# Configuration parameters: Max.
144254
RSpec/NestedGroups:
145-
Max: 6
255+
Exclude:
256+
- 'spec/slack/real_time/client_spec.rb'
257+
- 'spec/slack/web/api/pagination/cursor_spec.rb'
258+
- 'spec/slack/web/client_spec.rb'
146259

147260
# Offense count: 15
148261
# Cop supports --auto-correct.

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
### 0.14.5 (Next)
22

3+
* [#293](https://github.com/slack-ruby/slack-ruby-client/pull/293): Rubocop auto-correct and comprehensive todo - [@jcraigk](https://github.com/jcraigk).
34
* Your contribution here.
45

56
### 0.14.4 (2019/7/28)

0 commit comments

Comments
 (0)