Skip to content

Commit 911d7a8

Browse files
authored
Remove celluloid code (#355)
1 parent 1523246 commit 911d7a8

File tree

13 files changed

+6
-372
lines changed

13 files changed

+6
-372
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ matrix:
1414
- rvm: 2.4.1
1515
script:
1616
- bundle exec danger
17-
- rvm: 2.4.1
18-
env: CONCURRENCY=celluloid-io
1917
- rvm: 2.4.1
2018
env: CONCURRENCY=faye-websocket
2119
- rvm: 2.5.3

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
* [#348](https://github.com/slack-ruby/slack-ruby-client/pull/348): Added `admin_conversations_archive`, `admin_conversations_convertToPrivate`, `admin_conversations_create`, `admin_conversations_delete`, `admin_conversations_disconnectShared`, `admin_conversations_getConversationPrefs`, `admin_conversations_getTeams`, `admin_conversations_invite`, `admin_conversations_rename`, `admin_conversations_search`, `admin_conversations_setConversationPrefs`, `admin_conversations_unarchive`, `admin_conversations_ekm_listOriginalConnectedChannelInfo`, `admin_users_session_invalidate`, `apps_event_authorizations_list`, `conversations_mark`, `workflows_stepCompleted`, `workflows_stepFailed`, `workflows_updateStep` endpoints - [@wasabigeek](https://github.com/wasabigeek).
44
* [#350](https://github.com/slack-ruby/slack-ruby-client/pull/350): Handle server errors such as timouts & non-json responses (see [Upgrading to 0.16.0](UPGRADING.md#upgrading-to--0160)) - [@ojab](https://github.com/ojab).
55
* [#354](https://github.com/slack-ruby/slack-ruby-client/pull/354): Rewind body after checking request signature - [@sunny](https://github.com/sunny).
6+
* [#355](https://github.com/slack-ruby/slack-ruby-client/pull/355): Remove celluloid code - [@wasabigeek](https://github.com/wasabigeek).
67
* Your contribution here.
78

89
### 0.15.1 (2020/9/3)

README.md

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ A Ruby client for the Slack [Web](https://api.slack.com/web), [RealTime Messagin
4848
- [Concurrency](#concurrency)
4949
- [Async](#async)
5050
- [Faye::Websocket with Eventmachine](#fayewebsocket-with-eventmachine)
51-
- [Celluloid](#celluloid)
5251
- [Events API](#events-api)
5352
- [Configuring Slack::Events](#configuring-slackevents)
5453
- [Verifying the Request Signature](#verifying-the-request-signature)
@@ -82,7 +81,7 @@ Add to Gemfile.
8281
gem 'slack-ruby-client'
8382
```
8483

85-
If you're going to be using the RealTime client, add either `async-websocket`, `eventmachine` and `faye-websocket` or `celluloid-io`. See below for more information about concurrency. We recommend you use `async-websocket`.
84+
If you're going to be using the RealTime client, add either `async-websocket`, `eventmachine` and `faye-websocket`. See below for more information about concurrency. We recommend you use `async-websocket`.
8685

8786
```
8887
gem 'async-websocket', '~> 0.8.0'
@@ -495,7 +494,7 @@ See [#134](https://github.com/slack-ruby/slack-ruby-client/issues/134) for a dis
495494

496495
#### Concurrency
497496

498-
`Slack::RealTime::Client` needs help from a concurrency library and supports [Async](https://github.com/socketry/async), [Faye::WebSocket](https://github.com/faye/faye-websocket-ruby) with [Eventmachine](https://github.com/eventmachine/eventmachine) and [Celluloid](https://github.com/celluloid/celluloid). It will auto-detect one or the other depending on the gems in your Gemfile, but you can also set concurrency explicitly.
497+
`Slack::RealTime::Client` needs help from a concurrency library and supports [Async](https://github.com/socketry/async) and [Faye::WebSocket](https://github.com/faye/faye-websocket-ruby) with [Eventmachine](https://github.com/eventmachine/eventmachine). It will auto-detect one or the other depending on the gems in your Gemfile, but you can also set concurrency explicitly.
499498

500499
```ruby
501500
Slack::RealTime.configure do |config|
@@ -531,16 +530,6 @@ gem 'faye-websocket'
531530

532531
See a fully working example in [examples/hi_real_time_async_eventmachine](examples/hi_real_time_async_eventmachine/hi.rb).
533532

534-
##### Celluloid
535-
536-
Add the following to your Gemfile.
537-
538-
```
539-
gem 'celluloid-io', require: ['celluloid/current', 'celluloid/io']
540-
```
541-
542-
See a fully working example in [examples/hi_real_time_async_celluloid](examples/hi_real_time_async_celluloid/hi.rb).
543-
544533
### Events API
545534

546535
This library provides limited support for the [Slack Events API](https://api.slack.com/events-api).

examples/hi_real_time/Gemfile

Lines changed: 0 additions & 6 deletions
This file was deleted.

examples/hi_real_time/hi.gif

-141 KB
Binary file not shown.

examples/hi_real_time/hi.rb

Lines changed: 0 additions & 41 deletions
This file was deleted.

examples/hi_real_time_async_celluloid/Gemfile

Lines changed: 0 additions & 7 deletions
This file was deleted.

examples/hi_real_time_async_celluloid/Procfile

Lines changed: 0 additions & 2 deletions
This file was deleted.

examples/hi_real_time_async_celluloid/hi.rb

Lines changed: 0 additions & 39 deletions
This file was deleted.

lib/slack/real_time/concurrency.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ module RealTime
44
module Concurrency
55
autoload :Async, 'slack/real_time/concurrency/async'
66
autoload :Eventmachine, 'slack/real_time/concurrency/eventmachine'
7-
autoload :Celluloid, 'slack/real_time/concurrency/celluloid'
87
end
98
end
109
end

0 commit comments

Comments
 (0)