properly raise nested exception

gregsaab · gregsaab · commit 958db8fd0b60 · 2025-01-31T09:34:41.000-05:00
diff --git a/lib/slack/web/faraday/response/raise_error.rb b/lib/slack/web/faraday/response/raise_error.rb
@@ -11,7 +11,11 @@ def raise_if_too_many_requests!(env)
           def raise_if_response_is_invalid_json!(env)
             return if response_content_type_is_a_string?(env) || env.body.is_a?(Hash)
 
-            raise ::Faraday::ParsingError.new(nil, env.response)
+            begin
+              raise JSON::ParserError
+            rescue StandardError => e
+              raise ::Faraday::ParsingError.new(e, env.response)
+            end
           end
 
           def response_content_type_is_a_string?(env)
diff --git a/spec/slack/web/client_spec.rb b/spec/slack/web/client_spec.rb
@@ -295,6 +295,7 @@
             expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
             expect(exception.response.body).to eq('<html></html>')
             expect(exception.cause).to be_a(Faraday::ParsingError)
+            expect(exception.cause.cause).to be_a(JSON::ParserError)
           end
         end
 
@@ -305,6 +306,7 @@
             expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
             expect(exception.response.body).to eq('{')
             expect(exception.cause).to be_a(Faraday::ParsingError)
+            expect(exception.cause.cause).to be_a(JSON::ParserError)
           end
         end
       end
