Skip to content

Commit 96d93dc

Browse files
authored
Merge pull request #523 from dblock/fix-coveralls
Fix: coveralls closing builds.
2 parents efb0cb8 + 96f1328 commit 96d93dc

File tree

3 files changed

+19
-7
lines changed

3 files changed

+19
-7
lines changed

.github/workflows/test.yml

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
- { ruby: "3.3" }
1515
- { ruby: ruby-head, ignore: true }
1616
- { ruby: jruby-head, ignore: true }
17-
name: test (ruby=${{ matrix.entry.ruby }}, concurrency=${{ matrix.entry.concurrency || 'none' }})
17+
name: test (ruby=${{ matrix.entry.ruby }}${{ matrix.entry.concurrency && ', concurrency=' }}${{ matrix.entry.concurrency }})
1818
steps:
1919
- name: Checkout
2020
uses: actions/checkout@v4
@@ -35,8 +35,19 @@ jobs:
3535
RACK_ENV: test
3636
run: bundle exec rake
3737
- name: Coveralls
38-
uses: coverallsapp/github-action@master
38+
uses: coverallsapp/github-action@v2
3939
with:
40+
parallel: true
4041
github-token: ${{ secrets.GITHUB_TOKEN }}
41-
- name: Coveralls Finished
42-
uses: coverallsapp/github-action@master
42+
flag-name: run-${{ matrix.entry.ruby }}${{ matrix.entry.concurrency && '-'}}${{ matrix.entry.concurrency }}
43+
44+
finish:
45+
name: coveralls
46+
needs: test
47+
runs-on: ubuntu-latest
48+
steps:
49+
- name: Close Parallel Build
50+
uses: coverallsapp/github-action@v2
51+
with:
52+
parallel-finished: true
53+
carryforward: 'run-2.7,run-2.7-async-websocket,run-3.0,run-3.1,run-3.2,run-3.3'

CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
### 2.3.1 (Next)
1+
### 2.4.0 (Next)
22

33
* [#516](https://github.com/slack-ruby/slack-ruby-client/pull/516): Add support for Ruby 3.3 - [@olleolleolle](https://github.com/olleolleolle).
4-
* [#520](https://github.com/slack-ruby/slack-ruby-client/pull/520): Support basic markdown formatting - [@nbgoodall](https://github.com/nbgoodall).
4+
* [#520](https://github.com/slack-ruby/slack-ruby-client/pull/520): Add support for basic markdown formatting - [@nbgoodall](https://github.com/nbgoodall).
5+
* [#523](https://github.com/slack-ruby/slack-ruby-client/pull/523): Fix coveralls handling parallel jobs - [@dblock](https://github.com/dblock).
56
* Your contribution here.
67

78
### 2.3.0 (2024/01/31)

lib/slack/version.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# frozen_string_literal: true
22
module Slack
3-
VERSION = '2.3.1'
3+
VERSION = '2.4.0'
44
end

0 commit comments

Comments
 (0)