Prevent ping worker from dying on unexpected errors.

Author: dblock

CHANGELOG.md

@@ -1,5 +1,6 @@
 ### 0.14.3 (Next)
 
+* [#279](https://github.com/slack-ruby/slack-ruby-client/pull/279): Prevent ping worker from dying on unexpected errors - [@dblock](https://github.com/dblock).
 * Your contribution here.
 
 ### 0.14.2 (2019/4/12)

lib/slack/real_time/client.rb

@@ -128,6 +128,9 @@ def run_ping!
         return if keep_alive?
 
         restart_async
+      rescue StandardError => e
+        # disregard all ping worker failures, keep pinging
+        logger.debug("#{self.class}##{__method__}") { e }
       end
 
       def run_ping?

spec/slack/real_time/client_spec.rb

@@ -148,6 +148,15 @@
           expect(socket).to receive(:restart_async)
           client.run_ping!
         end
+        [EOFError, Errno::ECONNRESET, Errno::EPIPE, Faraday::ClientError].each do |err|
+          context "raising #{err}" do
+            it 'does not terminate the ping worker' do
+              allow(socket).to receive(:time_since_last_message) { raise err }
+              expect(socket).to_not receive(:send_data)
+              client.run_ping!
+            end
+          end
+        end
       end
     end
   end