Remove custom_specs override.

Author: dblock

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2025-02-08 15:52:13 UTC using RuboCop version 1.26.1.
+# on 2025-02-09 15:50:36 UTC using RuboCop version 1.26.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -73,7 +73,7 @@ Metrics/PerceivedComplexity:
 # Configuration parameters: MinSize.
 Performance/CollectionLiteralInLoop:
   Exclude:
-    - 'spec/slack/web/api/endpoints/custom_specs/files_spec.rb'
+    - 'spec/slack/web/api/endpoints/custom/files_spec.rb'
 
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
@@ -178,13 +178,6 @@ Rake/Desc:
   Exclude:
     - 'lib/tasks/git.rake'
 
-# Offense count: 1
-# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
-# SupportedStyles: inline, group
-Style/AccessModifierDeclarations:
-  Exclude:
-    - 'lib/slack/real_time/client.rb'
-
 # Offense count: 4
 # Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
 # SupportedStyles: annotated, template, unannotated
@@ -204,7 +197,7 @@ Style/GlobalStdStream:
 # This cop supports unsafe auto-correction (--auto-correct-all).
 Style/MapToHash:
   Exclude:
-    - 'spec/slack/web/api/endpoints/custom_specs/files_spec.rb'
+    - 'spec/slack/web/api/endpoints/custom/files_spec.rb'
 
 # Offense count: 1
 Style/MultilineBlockChain:
@@ -220,7 +213,7 @@ Style/MultilineTernaryOperator:
 # Offense count: 3
 Style/OpenStructUse:
   Exclude:
-    - 'spec/slack/web/api/endpoints/custom_specs/chat_spec.rb'
+    - 'spec/slack/web/api/endpoints/custom/chat_spec.rb'
     - 'spec/slack/web/api/pagination/cursor_spec.rb'
     - 'spec/slack/web/faraday/response/raise_error_spec.rb'
 

lib/slack/web/api/templates/method_spec.erb

@@ -11,18 +11,16 @@ RSpec.describe Slack::Web::Api::Endpoints::<%= group.gsub(".", "_").camelize %>
 <% required_params = data['args'].select{ |k, v| v['required'] } %>
 <% all_required_params = data['args'].select{ |k, v| v['required'] || group_required_params.include?(k) } %>
 <% json_params = data['args'].map { |arg_name, arg_v| arg_name if arg_v['format'] == 'json' }.compact %>
-<% next if (all_required_params.none? || custom_spec_exists) && json_params.none? && data['arg_groups'].nil? %>
+<% next if all_required_params.none? && json_params.none? && data['arg_groups'].nil? %>
 <% method_name = [group.gsub(".", "_"), name].join('_') %>
 <% example_params = all_required_params.to_h { |var, opts| [var, opts['example']] } %>
   context '<%= group %>_<%= name %>' do
-<% unless custom_spec_exists %>
 <% required_params.each do |arg_name, arg_v| %>
     it 'requires <%= arg_name %>' do
 <% params_except_required = example_params.reject { |name, _| name == arg_name  }.map { |name, val| "#{name}: %q[#{val}]" }.join(', ') %>
       expect { client.<%= method_name %><%= params_except_required.empty? ? '' : "(#{params_except_required})" %> }.to raise_error ArgumentError, /Required arguments :<%= arg_name %> missing/
     end
 <% end %>
-<% end %>
 <% data['arg_groups']&.each do |arg_group| %>
     <% next if arg_group['args'].size <= 1 %>
     it 'requires one of <%= arg_group['args'].join(', ') %>' do

lib/tasks/web.rake

@@ -56,9 +56,7 @@ namespace :slack do
           snaked_group = group.tr('.', '_')
           rendered_method = method_template.result(group: group, names: names)
           File.write "lib/slack/web/api/endpoints/#{snaked_group}.rb", rendered_method
-          custom_spec_exists =
-            File.exist?("spec/slack/web/api/endpoints/custom_specs/#{group}_spec.rb")
-          rendered_method_spec = method_spec_template.result(group: group, names: names, custom_spec_exists: custom_spec_exists)
+          rendered_method_spec = method_spec_template.result(group: group, names: names)
           File.write "spec/slack/web/api/endpoints/#{snaked_group}_spec.rb", rendered_method_spec
 
           unless ENV.key?('SKIP_PATCH')

spec/slack/web/api/endpoints/chat_spec.rb

@@ -5,7 +5,53 @@
 
 RSpec.describe Slack::Web::Api::Endpoints::Chat do
   let(:client) { Slack::Web::Client.new }
+  context 'chat_command' do
+    it 'requires channel' do
+      expect { client.chat_command(command: %q[/who]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires command' do
+      expect { client.chat_command(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :command missing/
+    end
+  end
+  context 'chat_delete' do
+    it 'requires channel' do
+      expect { client.chat_delete(ts: %q["1405894322.002768"]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires ts' do
+      expect { client.chat_delete(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :ts missing/
+    end
+  end
+  context 'chat_deleteScheduledMessage' do
+    it 'requires channel' do
+      expect { client.chat_deleteScheduledMessage(scheduled_message_id: %q[Q1234ABCD]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires scheduled_message_id' do
+      expect { client.chat_deleteScheduledMessage(channel: %q[C123456789]) }.to raise_error ArgumentError, /Required arguments :scheduled_message_id missing/
+    end
+  end
+  context 'chat_getPermalink' do
+    it 'requires channel' do
+      expect { client.chat_getPermalink(message_ts: %q[1234567890.123456]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires message_ts' do
+      expect { client.chat_getPermalink(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :message_ts missing/
+    end
+  end
+  context 'chat_meMessage' do
+    it 'requires channel' do
+      expect { client.chat_meMessage(text: %q[Hello world]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires text' do
+      expect { client.chat_meMessage(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :text missing/
+    end
+  end
   context 'chat_postEphemeral' do
+    it 'requires channel' do
+      expect { client.chat_postEphemeral(user: %q[U0BPQUNTA], attachments: %q[[{"pretext": "pre-hello", "text": "text-world"}]]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires user' do
+      expect { client.chat_postEphemeral(channel: %q[C1234567890], attachments: %q[[{"pretext": "pre-hello", "text": "text-world"}]]) }.to raise_error ArgumentError, /Required arguments :user missing/
+    end
     it 'requires one of attachments, blocks, text' do
       expect { client.chat_postEphemeral(channel: %q[C1234567890], user: %q[U0BPQUNTA]) }.to raise_error ArgumentError, /At least one of/
 
@@ -36,6 +82,9 @@
     end
   end
   context 'chat_postMessage' do
+    it 'requires channel' do
+      expect { client.chat_postMessage(attachments: %q[[{"pretext": "pre-hello", "text": "text-world"}]]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
     it 'requires one of attachments, blocks, text' do
       expect { client.chat_postMessage(channel: %q[C1234567890]) }.to raise_error ArgumentError, /At least one of/
 
@@ -66,6 +115,12 @@
     end
   end
   context 'chat_scheduleMessage' do
+    it 'requires channel' do
+      expect { client.chat_scheduleMessage(post_at: %q[299876400], attachments: %q[[{"pretext": "pre-hello", "text": "text-world"}]]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires post_at' do
+      expect { client.chat_scheduleMessage(channel: %q[C1234567890], attachments: %q[[{"pretext": "pre-hello", "text": "text-world"}]]) }.to raise_error ArgumentError, /Required arguments :post_at missing/
+    end
     it 'requires one of attachments, blocks, text' do
       expect { client.chat_scheduleMessage(channel: %q[C1234567890], post_at: %q[299876400]) }.to raise_error ArgumentError, /At least one of/
 
@@ -96,12 +151,27 @@
     end
   end
   context 'chat_unfurl' do
+    it 'requires channel' do
+      expect { client.chat_unfurl(ts: %q[], unfurls: %q[]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires ts' do
+      expect { client.chat_unfurl(channel: %q[C1234567890], unfurls: %q[]) }.to raise_error ArgumentError, /Required arguments :ts missing/
+    end
+    it 'requires unfurls' do
+      expect { client.chat_unfurl(channel: %q[C1234567890], ts: %q[]) }.to raise_error ArgumentError, /Required arguments :unfurls missing/
+    end
     it 'encodes unfurls, user_auth_blocks as json' do
       expect(client).to receive(:post).with('chat.unfurl', {channel: %q[C1234567890], ts: %q[], unfurls: %q[{"data":["data"]}], user_auth_blocks: %q[{"data":["data"]}]})
       client.chat_unfurl(channel: %q[C1234567890], ts: %q[], unfurls: {:data=>["data"]}, user_auth_blocks: {:data=>["data"]})
     end
   end
   context 'chat_update' do
+    it 'requires channel' do
+      expect { client.chat_update(ts: %q["1405894322.002768"], attachments: %q[[{"pretext": "pre-hello", "text": "text-world"}]]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires ts' do
+      expect { client.chat_update(channel: %q[C1234567890], attachments: %q[[{"pretext": "pre-hello", "text": "text-world"}]]) }.to raise_error ArgumentError, /Required arguments :ts missing/
+    end
     it 'requires one of attachments, blocks, text' do
       expect { client.chat_update(channel: %q[C1234567890], ts: %q["1405894322.002768"]) }.to raise_error ArgumentError, /At least one of/
 

spec/slack/web/api/endpoints/conversations_spec.rb

@@ -5,4 +5,125 @@
 
 RSpec.describe Slack::Web::Api::Endpoints::Conversations do
   let(:client) { Slack::Web::Client.new }
+  context 'conversations_acceptSharedInvite' do
+    it 'requires channel_name' do
+      expect { client.conversations_acceptSharedInvite }.to raise_error ArgumentError, /Required arguments :channel_name missing/
+    end
+  end
+  context 'conversations_approveSharedInvite' do
+    it 'requires invite_id' do
+      expect { client.conversations_approveSharedInvite }.to raise_error ArgumentError, /Required arguments :invite_id missing/
+    end
+  end
+  context 'conversations_archive' do
+    it 'requires channel' do
+      expect { client.conversations_archive }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_close' do
+    it 'requires channel' do
+      expect { client.conversations_close }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_create' do
+    it 'requires name' do
+      expect { client.conversations_create }.to raise_error ArgumentError, /Required arguments :name missing/
+    end
+  end
+  context 'conversations_declineSharedInvite' do
+    it 'requires invite_id' do
+      expect { client.conversations_declineSharedInvite }.to raise_error ArgumentError, /Required arguments :invite_id missing/
+    end
+  end
+  context 'conversations_history' do
+    it 'requires channel' do
+      expect { client.conversations_history }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_info' do
+    it 'requires channel' do
+      expect { client.conversations_info }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_invite' do
+    it 'requires channel' do
+      expect { client.conversations_invite(users: %q[W1234567890,U2345678901,U3456789012]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires users' do
+      expect { client.conversations_invite(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :users missing/
+    end
+  end
+  context 'conversations_inviteShared' do
+    it 'requires channel' do
+      expect { client.conversations_inviteShared }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_join' do
+    it 'requires channel' do
+      expect { client.conversations_join }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_kick' do
+    it 'requires channel' do
+      expect { client.conversations_kick(user: %q[W1234567890]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires user' do
+      expect { client.conversations_kick(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :user missing/
+    end
+  end
+  context 'conversations_leave' do
+    it 'requires channel' do
+      expect { client.conversations_leave }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_mark' do
+    it 'requires channel' do
+      expect { client.conversations_mark(ts: %q[1593473566.000200]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires ts' do
+      expect { client.conversations_mark(channel: %q[C012345678]) }.to raise_error ArgumentError, /Required arguments :ts missing/
+    end
+  end
+  context 'conversations_members' do
+    it 'requires channel' do
+      expect { client.conversations_members }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
+  context 'conversations_rename' do
+    it 'requires channel' do
+      expect { client.conversations_rename(name: %q[]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires name' do
+      expect { client.conversations_rename(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :name missing/
+    end
+  end
+  context 'conversations_replies' do
+    it 'requires channel' do
+      expect { client.conversations_replies(ts: %q[1234567890.123456]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires ts' do
+      expect { client.conversations_replies(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :ts missing/
+    end
+  end
+  context 'conversations_setPurpose' do
+    it 'requires channel' do
+      expect { client.conversations_setPurpose(purpose: %q[This is the random channel, anything goes!]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires purpose' do
+      expect { client.conversations_setPurpose(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :purpose missing/
+    end
+  end
+  context 'conversations_setTopic' do
+    it 'requires channel' do
+      expect { client.conversations_setTopic(topic: %q[Apply topically for best effects]) }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+    it 'requires topic' do
+      expect { client.conversations_setTopic(channel: %q[C1234567890]) }.to raise_error ArgumentError, /Required arguments :topic missing/
+    end
+  end
+  context 'conversations_unarchive' do
+    it 'requires channel' do
+      expect { client.conversations_unarchive }.to raise_error ArgumentError, /Required arguments :channel missing/
+    end
+  end
 end