Skip to content

Commit 9edd5ff

Browse files
committed
Fix: don't generate 1-parameter tests for mutually exclusive parameters.
1 parent 4d5d8da commit 9edd5ff

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

lib/slack/web/api/templates/method_spec.erb

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,12 @@ RSpec.describe Slack::Web::Api::Endpoints::<%= group.gsub(".", "_").camelize %>
88
<% names.sort.each_with_index do |(name, data), index| %>
99
<% next if data['mixin'] %>
1010
<% group_required_params = data['arg_groups']&.map { |grp| grp['args'].first if grp['args'].size > 1 } || [] %>
11-
<% required_params = data['args'].select{ |k, v| v['required'] || group_required_params.include?(k) } %>
11+
<% required_params = data['args'].select{ |k, v| v['required'] } %>
12+
<% all_required_params = data['args'].select{ |k, v| v['required'] || group_required_params.include?(k) } %>
1213
<% json_params = data['args'].map { |arg_name, arg_v| arg_name if arg_v['format'] == 'json' }.compact %>
13-
<% next if (required_params.none? || custom_spec_exists) && json_params.none? && data['arg_groups'].nil? %>
14+
<% next if (all_required_params.none? || custom_spec_exists) && json_params.none? && data['arg_groups'].nil? %>
1415
<% method_name = [group.gsub(".", "_"), name].join('_') %>
15-
<% example_params = required_params.to_h { |var, opts| [var, opts['example']] } %>
16+
<% example_params = all_required_params.to_h { |var, opts| [var, opts['example']] } %>
1617
context '<%= group %>_<%= name %>' do
1718
<% unless custom_spec_exists %>
1819
<% required_params.each do |arg_name, arg_v| %>

0 commit comments

Comments
 (0)