Skip to content

Commit cf6d601

Browse files
committed
Reduce logger noise.
1 parent 3a9df01 commit cf6d601

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
### 0.14.2 (Next)
22

33
* [#256](https://github.com/slack-ruby/slack-ruby-client/pull/256): Added support for specifying signing secrets on a per-request basis via optional parameters to the `Slack::Events::Request` constructor - [@gabrielmdeal](https://github.com/gabrielmdeal).
4-
* [#262](https://github.com/slack-ruby/slack-ruby-client/pull/262): Better handling of `disconnect!`/`close` - [@ioquatix](https://github.com/ioquatix).
4+
* [#257](https://github.com/slack-ruby/slack-ruby-client/pull/257), [#262](https://github.com/slack-ruby/slack-ruby-client/pull/262): Fixed occasional failures to reconnect - [@ioquatix](https://github.com/ioquatix), [@dblock](https://github.com/dblock).
55
* Your contribution here.
66

77
### 0.14.1 (2019/2/26)

lib/slack/real_time/concurrency/async.rb

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,13 @@ def start_reactor(client)
4444
@client_task.stop if @client_task
4545

4646
@client_task = task.async do |subtask|
47-
subtask.annotate 'client run-loop'
48-
client.run_loop
47+
begin
48+
subtask.annotate 'client run-loop'
49+
client.run_loop
50+
rescue ::Async::Wrapper::Cancelled => e
51+
# Will get restarted by ping worker.
52+
client.logger.warn(subtask.to_s) { e.message }
53+
end
4954
end
5055

5156
@restart.wait

0 commit comments

Comments
 (0)