permit string response if that's the content-type

gregsaab · gregsaab · commit d8a0d7a2ba7b · 2025-01-30T17:41:39.000-05:00
diff --git a/lib/slack/web/faraday/response/raise_error.rb b/lib/slack/web/faraday/response/raise_error.rb
@@ -7,10 +7,14 @@ class RaiseError < ::Faraday::Middleware
           def on_complete(env)
             raise Slack::Web::Api::Errors::TooManyRequestsError, env.response if env.status == 429
 
+            response_content_type_is_string = env.response&.headers&.[]('content-type')&.include?('text/plain') || false
+
+            raise ::Faraday::ParsingError.new(nil, env.response) if !response_content_type_is_string && !env.body.is_a?(Hash)
+
             return unless env.success?
 
             body = env.body
-            return if env.success? && body.is_a?(String)
+            return if env.success? && body.is_a?(String) && response_content_type_is_string
             return unless body
             return if body['ok']
 
diff --git a/spec/slack/web/client_spec.rb b/spec/slack/web/client_spec.rb
@@ -295,7 +295,6 @@
             expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
             expect(exception.response.body).to eq('<html></html>')
             expect(exception.cause).to be_a(Faraday::ParsingError)
-            expect(exception.cause.cause).to be_a(JSON::ParserError)
           end
         end
 
@@ -306,7 +305,6 @@
             expect { request }.to raise_error(Slack::Web::Api::Errors::ParsingError).with_message('parsing_error')
             expect(exception.response.body).to eq('{')
             expect(exception.cause).to be_a(Faraday::ParsingError)
-            expect(exception.cause.cause).to be_a(JSON::ParserError)
           end
         end
       end
