remove extra parameter, determine if response should be parsed into json based on the request type

Author: gregsaab

lib/slack/web/api/helpers/files.rb

@@ -44,7 +44,7 @@ def files_upload_v2(options = {})
             file_id = get_upload_url_response[:file_id]
 
             # 2. upload the file and do not process the return body
-            post(upload_url, content, false)
+            post(upload_url, content)
 
             # 3. complete the upload
             complete_upload_request_params = options.slice(:channels, :initial_comment, :thread_ts)

lib/slack/web/faraday/connection.rb

@@ -37,7 +37,7 @@ def connection
         end
 
         def connection_without_response_parsing
-          @connection_without_response_parsing ||= create_connection(false)
+          @connection_without_response_parsing ||= create_connection(expect_json_response: false)
         end
 
         private :create_connection

lib/slack/web/faraday/request.rb

@@ -3,25 +3,26 @@ module Slack
   module Web
     module Faraday
       module Request
-        def get(path, options = {}, expect_json_response: true)
-          request(:get, path, options, expect_json_response)
+        def get(path, options = {})
+          request(:get, path, options)
         end
 
-        def post(path, options = {}, expect_json_response: true)
-          request(:post, path, options, expect_json_response)
+        def post(path, options = {})
+          request(:post, path, options)
         end
 
-        def put(path, options = {}, expect_json_response: true)
-          request(:put, path, options, expect_json_response)
+        def put(path, options = {})
+          request(:put, path, options)
         end
 
-        def delete(path, options = {}, expect_json_response: true)
-          request(:delete, path, options, expect_json_response)
+        def delete(path, options = {})
+          request(:delete, path, options)
         end
 
         private
 
-        def request(method, path, options, expect_json_response)
+        def request(method, path, options)
+          expect_json_response = options.is_a? Hash
           connection_to_use = expect_json_response ? connection : connection_without_response_parsing
           response = connection_to_use.send(method) do |request|
             case method