Merge branch 'main' into honnor-passing-bolt-logger-in-default-web-client-installation

Author: WilliamBergamin

.github/maintainers_guide.md

@@ -103,11 +103,11 @@ If you want to test the package locally you can.
    - This will create a `.whl` file in the `./dist` folder
 2. Use the built package
    - Example `/dist/slack_bolt-1.2.3-py2.py3-none-any.whl` was created
-   - From anywhere on your machine you can install this package to a project with 
+   - From anywhere on your machine you can install this package to a project with
      ```bash
      pip install <project path>/dist/slack_bolt-1.2.3-py2.py3-none-any.whl
      ```
-   - It is also possible to include `<project path>/dist/slack_bolt-1.2.3-py2.py3-none-any.whl` in a [requirements.txt](https://pip.pypa.io/en/stable/user_guide/#requirements-files) file
+   - It is also possible to include `slack_bolt @ file:///<project path>/dist/slack_bolt-1.2.3-py2.py3-none-any.whl` in a [requirements.txt](https://pip.pypa.io/en/stable/user_guide/#requirements-files) file
 
 ### Releasing
 

tests/scenario_tests/test_web_client_customization.py

@@ -23,7 +23,10 @@ class TestWebClientCustomization:
     mock_api_server_base_url = "http://localhost:8888"
     signature_verifier = SignatureVerifier(signing_secret)
     test_logger = logging.getLogger("test.logger")
-    web_client = WebClient(token=valid_token, base_url=mock_api_server_base_url)
+    web_client = WebClient(
+        token=valid_token,
+        base_url=mock_api_server_base_url,
+    )
 
     def setup_method(self):
         self.old_os_env = remove_os_env_temporarily()
@@ -68,11 +71,19 @@ def listener(ack, client):
         assert response.body == ""
         assert_auth_test_count(self, 1)
 
-    def test_default_app_web_client_logger_is_app_logger(self):
+    def test_web_client_logger_is_default_app_logger(self):
         app = App(token=self.valid_token, signing_secret=self.signing_secret, token_verification_enabled=False)
-        app.client.base_url = self.mock_api_server_base_url
+        assert app.client._logger == app.logger  # TODO: use client.logger when available
 
-        assert app.client.logger == app.logger
+    def test_web_client_logger_is_app_logger(self):
+        app = App(
+            token=self.valid_token,
+            signing_secret=self.signing_secret,
+            logger=self.test_logger,
+            token_verification_enabled=False,
+        )
+        assert app.client._logger == app.logger  # TODO: use client.logger when available
+        assert app.client._logger == self.test_logger  # TODO: use client.logger when available
 
     def test_default_web_client_uses_bolt_framework_logger(self):
         app = App(token=self.valid_token, signing_secret=self.signing_secret, token_verification_enabled=False)

tests/scenario_tests_async/test_web_client_customization.py

@@ -89,11 +89,14 @@ async def listener(ack, client):
         assert response.body == ""
         await assert_auth_test_count_async(self, 1)
 
-    def test_default_app_web_client_logger_is_app_logger(self):
+    def test_web_client_logger_is_default_app_logger(self):
         app = AsyncApp(token=self.valid_token, signing_secret=self.signing_secret)
-        app.client.base_url = self.mock_api_server_base_url
+        assert app.client._logger == app.logger  # TODO: use client.logger when available
 
-        assert app.client.logger == app.logger
+    def test_web_client_logger_is_app_logger(self):
+        app = AsyncApp(token=self.valid_token, signing_secret=self.signing_secret, logger=self.test_logger)
+        assert app.client._logger == app.logger  # TODO: use client.logger when available
+        assert app.client._logger == self.test_logger  # TODO: use client.logger when available
 
     @pytest.mark.asyncio
     async def test_default_web_client_uses_bolt_framework_logger(self):