Enable developers to define app.message listener without args to capture all messages (#848)

Author: seratch

slack_bolt/app/app.py

@@ -743,7 +743,7 @@ def __call__(*args, **kwargs):
 
     def message(
         self,
-        keyword: Union[str, Pattern],
+        keyword: Union[str, Pattern] = "",
         matchers: Optional[Sequence[Callable[..., bool]]] = None,
         middleware: Optional[Sequence[Union[Callable, Middleware]]] = None,
     ) -> Callable[..., Optional[Callable[..., Optional[BoltResponse]]]]:

slack_bolt/app/async_app.py

@@ -773,7 +773,7 @@ def __call__(*args, **kwargs):
 
     def message(
         self,
-        keyword: Union[str, Pattern],
+        keyword: Union[str, Pattern] = "",
         matchers: Optional[Sequence[Callable[..., Awaitable[bool]]]] = None,
         middleware: Optional[Sequence[Union[Callable, AsyncMiddleware]]] = None,
     ) -> Callable[..., Optional[Callable[..., Awaitable[Optional[BoltResponse]]]]]:

tests/scenario_tests/test_message.py

@@ -74,6 +74,40 @@ def test_string_keyword(self):
         time.sleep(1)  # wait a bit after auto ack()
         assert self.mock_received_requests["/chat.postMessage"] == 1
 
+    def test_all_message_matching_1(self):
+        app = App(
+            client=self.web_client,
+            signing_secret=self.signing_secret,
+        )
+
+        @app.message("")
+        def handle_all_new_messages(say):
+            say("Thanks!")
+
+        request = self.build_request2()
+        response = app.dispatch(request)
+        assert response.status == 200
+        assert_auth_test_count(self, 1)
+        time.sleep(1)  # wait a bit after auto ack()
+        assert self.mock_received_requests["/chat.postMessage"] == 1
+
+    def test_all_message_matching_2(self):
+        app = App(
+            client=self.web_client,
+            signing_secret=self.signing_secret,
+        )
+
+        @app.message()
+        def handle_all_new_messages(say):
+            say("Thanks!")
+
+        request = self.build_request2()
+        response = app.dispatch(request)
+        assert response.status == 200
+        assert_auth_test_count(self, 1)
+        time.sleep(1)  # wait a bit after auto ack()
+        assert self.mock_received_requests["/chat.postMessage"] == 1
+
     def test_string_keyword_capturing(self):
         app = App(
             client=self.web_client,

tests/scenario_tests_async/test_message.py

@@ -81,6 +81,42 @@ async def test_string_keyword(self):
         await asyncio.sleep(1)  # wait a bit after auto ack()
         assert self.mock_received_requests["/chat.postMessage"] == 1
 
+    @pytest.mark.asyncio
+    async def test_all_message_matching_1(self):
+        app = AsyncApp(
+            client=self.web_client,
+            signing_secret=self.signing_secret,
+        )
+
+        @app.message("")
+        async def handle_all_new_messages(say):
+            await say("Thanks!")
+
+        request = self.build_request2()
+        response = await app.async_dispatch(request)
+        assert response.status == 200
+        await assert_auth_test_count_async(self, 1)
+        await asyncio.sleep(1)  # wait a bit after auto ack()
+        assert self.mock_received_requests["/chat.postMessage"] == 1
+
+    @pytest.mark.asyncio
+    async def test_all_message_matching_2(self):
+        app = AsyncApp(
+            client=self.web_client,
+            signing_secret=self.signing_secret,
+        )
+
+        @app.message()
+        async def handle_all_new_messages(say):
+            await say("Thanks!")
+
+        request = self.build_request2()
+        response = await app.async_dispatch(request)
+        assert response.status == 200
+        await assert_auth_test_count_async(self, 1)
+        await asyncio.sleep(1)  # wait a bit after auto ack()
+        assert self.mock_received_requests["/chat.postMessage"] == 1
+
     @pytest.mark.asyncio
     async def test_string_keyword_capturing(self):
         app = AsyncApp(